remove obsolete setup functions from tests#225
Merged
dirk-thomas merged 1 commit intomasterfrom Jan 16, 2018
Merged
Conversation
f449e73 to
498cfeb
Compare
Member
Author
|
I removed the second commit since it didn't improve the test results noticeably. Now the patch is only removing the obsolete |
|
|
||
| def setup(): | ||
| # bare minimum formatting for console output matching | ||
| os.environ['RCUTILS_CONSOLE_OUTPUT_FORMAT'] = '{message}' |
Member
There was a problem hiding this comment.
Nit: import os seems obsolete now
Member
Author
There was a problem hiding this comment.
Thanks for catching this. Fixed.
498cfeb to
0748c4f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just the composition tests:
And with
--retest-until-fail 20:I will likely go ahead and merge this in order to get the next round of nightlies using this. As before I will of course address any comments / feedback (if there is any).Update: I am not convinced this patch (the second commit with the delay) is any improvement based on the repeated test results...