Conversation
added 2 commits
July 24, 2019 13:09
Signed-off-by: Siddharth Kucheria <kucheria@usc.edu>
Signed-off-by: Siddharth Kucheria <kucheria@usc.edu>
89800b3 to
72c1fe7
Compare
jacobperron
reviewed
Jul 24, 2019
Member
jacobperron
left a comment
There was a problem hiding this comment.
I think we can add the CPP tutorials to the existing action_tutorials package, unless there's a good reason not to.
b972ec7 to
916f9d4
Compare
672bda4 to
fdb85a5
Compare
Signed-off-by: Siddharth Kucheria <kucheria@usc.edu>
fdb85a5 to
cde78b1
Compare
jacobperron
reviewed
Aug 6, 2019
action_tutorials/action_tutorials_cpp/include/action_tutorials_cpp/visibility_control.h
Show resolved
Hide resolved
action_tutorials/action_tutorials_cpp/src/fibonacci_action_client.cpp
Outdated
Show resolved
Hide resolved
action_tutorials/action_tutorials_cpp/src/fibonacci_action_client.cpp
Outdated
Show resolved
Hide resolved
added 2 commits
August 6, 2019 13:13
Signed-off-by: Siddharth Kucheria <kucheria@usc.edu>
jacobperron
approved these changes
Aug 6, 2019
Member
jacobperron
left a comment
There was a problem hiding this comment.
Two small things, otherwise, LGTM
Co-Authored-By: Jacob Perron <jacob@openrobotics.org>
Member
Author
|
jacobperron
approved these changes
Aug 7, 2019
Member
|
@skucheria Please open an issue on https://github.com/ros2/ros2_documentation for updating the existing tutorials to match the changes in this repo. ros2/ros2_documentation#277 already exists for adding C++ tutorials. |
jacobperron
added a commit
to ros2/ros2cli
that referenced
this pull request
Aug 7, 2019
The original package was refactored into action_tutorials_py and action_tutorials_interfaces in ros2/demos#378 Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
added a commit
to ros2/ros2cli
that referenced
this pull request
Aug 9, 2019
* Rename action_tutorials dependency The original package was refactored into action_tutorials_py and action_tutorials_interfaces in ros2/demos#378 Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Replace ExecuteProcess action with Node action Signed-off-by: Jacob Perron <jacob@openrobotics.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.