Skip to content

Rename action_tutorials dependency#310

Merged
jacobperron merged 2 commits intomasterfrom
jacob/rename_action_tutorials_pkg
Aug 9, 2019
Merged

Rename action_tutorials dependency#310
jacobperron merged 2 commits intomasterfrom
jacob/rename_action_tutorials_pkg

Conversation

@jacobperron
Copy link
Copy Markdown
Member

@jacobperron jacobperron commented Aug 7, 2019 •
edited
Loading

The original package was refactored into action_tutorials_py and action_tutorials_interfaces in ros2/demos#378

Resolves ros2/build_farmer#222

Linux CI Before: Build Status

CI after:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@jacobperron
Rename action_tutorials dependency
9ebbf7d 
The original package was refactored into action_tutorials_py and action_tutorials_interfaces in ros2/demos#378

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@dirk-thomas
Copy link
Copy Markdown
Member

dirk-thomas commented Aug 7, 2019

👍 for the patch.

But why does the Linux build only show one of the two tests (Connext but not FastRTPS)?

@jacobperron
Copy link
Copy Markdown
Member Author

jacobperron commented Aug 8, 2019

But why does the Linux build only show one of the two tests (Connext but not FastRTPS)?

I don't know.. I'll investigate that along with the Windows test failures.

cottsay
cottsay approved these changes Aug 8, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@cottsay cottsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to address the CI job failures on build.ros2.org as well: http://build.ros2.org/view/Eci/job/Eci__nightly-release_ubuntu_bionic_amd64/48/console#console-section-8

@cottsay cottsay mentioned this pull request Aug 8, 2019
Closed
@jacobperron
Copy link
Copy Markdown
Member Author

jacobperron commented Aug 8, 2019

Here the tests pass for Fast-RTPS (I disabled Connext): Build Status

I'm not sure why when Connext is enabled then only one of the tests runs. Could be a bug in the CMakeLists.txt of test_ros2cli?

@jacobperron jacobperron mentioned this pull request Aug 9, 2019
Merged
@ivanpauno ivanpauno mentioned this pull request Aug 9, 2019
Closed
dirk-thomas
dirk-thomas approved these changes Aug 9, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@dirk-thomas dirk-thomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge anyway since this breaks the nightly CI builds atm.

ivanpauno
ivanpauno reviewed Aug 9, 2019
View reviewed changes
@jacobperron
Replace ExecuteProcess action with Node action
a36df3a 
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Copy link
Copy Markdown
Member Author

jacobperron commented Aug 9, 2019 •
edited
Loading

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@mikaelarguedas mikaelarguedas mentioned this pull request Aug 9, 2019
Closed
ivanpauno
ivanpauno approved these changes Aug 9, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@ivanpauno ivanpauno left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what are the windows failures, I will dig in the problem when I get a VM.
I think we can merge this one in the meantime.

@jacobperron jacobperron merged commit 0ce8efa into master Aug 9, 2019
@delete-merged-branch delete-merged-branch bot deleted the jacob/rename_action_tutorials_pkg branch August 9, 2019 17:29
@jacobperron jacobperron mentioned this pull request Aug 9, 2019
Closed
@jacobperron
Copy link
Copy Markdown
Member Author

jacobperron commented Aug 9, 2019

Opened an issue for visibility: #313

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wjwwood wjwwood wjwwood approved these changes

@cottsay cottsay cottsay approved these changes

@ivanpauno ivanpauno ivanpauno approved these changes

+1 more reviewer

@dirk-thomas dirk-thomas dirk-thomas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test_ros2action started failing last night across all platforms

5 participants

@jacobperron @dirk-thomas @wjwwood @cottsay @ivanpauno