Use standard urdfdom-headers rosdep key.#6
Merged
nuclearsandwich merged 1 commit intoros2from Jun 20, 2017
Merged
Conversation
We're shadowing this key for r2b2 since upstream is out of date but we should use the rosdep key so we can eventually target upstream. ros2/robot_model#1
mikaelarguedas
approved these changes
Jun 20, 2017
Member
mikaelarguedas
left a comment
There was a problem hiding this comment.
lgtm, knowing that this will shadow the system one as mentioned in ros2/robot_model#1 (comment)
nuclearsandwich
added a commit
that referenced
this pull request
Jun 20, 2017
This reverts commit 0dbd82a.
nuclearsandwich
added a commit
that referenced
this pull request
Jun 20, 2017
mikaelarguedas
pushed a commit
that referenced
this pull request
May 17, 2018
It was only being used for boost::array, which we can easily replace with std::array. Signed-off-by: Chris Lalancette <clalancette@osrfoundation.org> Port cartographer_ros_msgs over to ROS2. The messages and services now build. Signed-off-by: Chris Lalancette <clalancette@osrfoundation.org> Port cartographer_ros over to ROS2. Signed-off-by: Chris Lalancette <clalancette@osrfoundation.org> Always get the tf transform right "now". We are currently having problems with rounding in tf, which causes it to always miss the transform. To work around this for now, just always ask for the latest transform. This isn't technically correct, but will probably be good enough for Turtlebot where our transforms are static. Signed-off-by: Chris Lalancette <clalancette@osrfoundation.org> Disable testing in cartographer_ros. This is to avoid an error when building without google-mock installed. Signed-off-by: Chris Lalancette <clalancette@osrfoundation.org> Add in configuration files for turtlebot 2d and 3d. Signed-off-by: Chris Lalancette <clalancette@osrfoundation.org> Make sure to ignore building the cartographer_ros_docs. We don't currently have a configuration that will allow these to build. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> Make sure to include trajectory_builder.lua for 3d. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> Update to use tf2::durationFromSec (#3) Internal storage has been converted from <ns, double> to <ns, int> use CMAKE_X_STANDARD and check compiler rather than platform Use standard urdfdom-headers rosdep key. (#6) We're shadowing this key for r2b2 since upstream is out of date but we should use the rosdep key so we can eventually target upstream. ros2/robot_model#1 Revert "Use standard urdfdom-headers rosdep key. (#6)" (#7) This reverts commit 0dbd82a. Move executables to libexec directory (#9) * Move into lib directory. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * move turtlebot config files to turtlebot_cartographer package Make cartographer_ros compile again with recent changes to rclcpp::Time (#12) * Make cartographer_ros compile again with recent changes to rclcpp::Time Signed-off-by: Chris Lalancette <clalancette@osrfoundation.org> * Fix nits from review. Signed-off-by: Chris Lalancette <clalancette@osrfoundation.org> * Fix up alphabetical order. Signed-off-by: Chris Lalancette <clalancette@osrfoundation.org> * Store the timesource and the clock in the node. This way we don't re-initialize it every time. Signed-off-by: Chris Lalancette <clalancette@osrfoundation.org> migrate to format 3 and declare membership to rosidl_interface_packages (#13) Update for rclcpp namespace removals (#14) * Remove ::publisher:: namespace * Remove subscription:: namespace * Remove service:: namespace * Remove timer:: namespace * Remove node:: namespace Update the maintainer to me. (#15) * Update the maintainer to me. * Updates from review. * fixup 2.0.0
mikaelarguedas
pushed a commit
that referenced
this pull request
May 17, 2018
Remove boost from cartographer_ros. It was only being used for boost::array, which we can easily replace with std::array. Signed-off-by: Chris Lalancette <clalancette@osrfoundation.org> Port cartographer_ros_msgs over to ROS2. The messages and services now build. Signed-off-by: Chris Lalancette <clalancette@osrfoundation.org> Port cartographer_ros over to ROS2. Signed-off-by: Chris Lalancette <clalancette@osrfoundation.org> Always get the tf transform right "now". We are currently having problems with rounding in tf, which causes it to always miss the transform. To work around this for now, just always ask for the latest transform. This isn't technically correct, but will probably be good enough for Turtlebot where our transforms are static. Signed-off-by: Chris Lalancette <clalancette@osrfoundation.org> Disable testing in cartographer_ros. This is to avoid an error when building without google-mock installed. Signed-off-by: Chris Lalancette <clalancette@osrfoundation.org> Add in configuration files for turtlebot 2d and 3d. Signed-off-by: Chris Lalancette <clalancette@osrfoundation.org> Make sure to ignore building the cartographer_ros_docs. We don't currently have a configuration that will allow these to build. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> Make sure to include trajectory_builder.lua for 3d. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> Update to use tf2::durationFromSec (#3) Internal storage has been converted from <ns, double> to <ns, int> use CMAKE_X_STANDARD and check compiler rather than platform Use standard urdfdom-headers rosdep key. (#6) We're shadowing this key for r2b2 since upstream is out of date but we should use the rosdep key so we can eventually target upstream. ros2/robot_model#1 Revert "Use standard urdfdom-headers rosdep key. (#6)" (#7) This reverts commit 0dbd82a. Move executables to libexec directory (#9) * Move into lib directory. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * move turtlebot config files to turtlebot_cartographer package Make cartographer_ros compile again with recent changes to rclcpp::Time (#12) * Make cartographer_ros compile again with recent changes to rclcpp::Time Signed-off-by: Chris Lalancette <clalancette@osrfoundation.org> * Fix nits from review. Signed-off-by: Chris Lalancette <clalancette@osrfoundation.org> * Fix up alphabetical order. Signed-off-by: Chris Lalancette <clalancette@osrfoundation.org> * Store the timesource and the clock in the node. This way we don't re-initialize it every time. Signed-off-by: Chris Lalancette <clalancette@osrfoundation.org> migrate to format 3 and declare membership to rosidl_interface_packages (#13) Update for rclcpp namespace removals (#14) * Remove ::publisher:: namespace * Remove subscription:: namespace * Remove service:: namespace * Remove timer:: namespace * Remove node:: namespace Update the maintainer to me. (#15) * Update the maintainer to me. * Updates from review. * fixup 2.0.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're shadowing this key for r2b2 since upstream is out of date but we should
use the rosdep key so we can eventually target upstream.
ros2/robot_model#1