[Windows][melodic] add missing DLL exports.#1335
[Windows][melodic] add missing DLL exports.#1335rhaschke merged 3 commits intoros-visualization:wip-windows-portfrom ms-iot:windows_port_rviz_decl
Conversation
rhaschke
left a comment
There was a problem hiding this comment.
I suggest to use cmake's functions generate_export_header and rename rviz_macros.h to rviz_export.h, because the include only deals with export definitions.
src/rviz/default_plugin/interactive_markers/interactive_marker.h
Outdated
Show resolved
Hide resolved
The primary reason is we saw that many ROS projects have been already following this ROS Wiki to define the exports header, and figured we are not going to use another idiom to diverge from this existing one for ROS1 community. What do you think? |
|
The ROS wiki page was created back in 2013, when cmake didn't yet provided this neat function. |
Understood. I switched the implementation to make use of CMake built-in generate_export_header. |
|
|
Yes, I know. Please file a bug at https://github.com/fkie/catkin_lint. |
|
@rhaschke Thanks. |
|
Looking into this error... |
|
travis CI errors are fixed. |
|
@rhaschke this is ready for another round of review. Let me know if any feedbacks, thanks! |
standardized the minimum cmake version required to the minimum needed to compile ogre "3.10". this also fixes numerous warnings (cmake<3.10 deprecation) when compiling with modern cmake versions
Define DLL exports for rviz (http://wiki.ros.org/win_ros/Contributing/Dll%20Exports).
This change is verified by https://aka.ms/ros project.