Merged
Conversation
mlautman
added a commit
that referenced
this pull request
Dec 12, 2018
mlautman
added a commit
that referenced
this pull request
Dec 12, 2018
Contributor
|
Please don't "hide" completely unrelated changes like the QoS one in a commit / PR with a completely different title. It will be almost impossible to spot in the future when looking at commits and pull requests. |
Member
Author
|
@dirk-thomas My bad. I was working fast and using |
mlautman
added a commit
that referenced
this pull request
Dec 18, 2018
mlautman
added a commit
that referenced
this pull request
Dec 18, 2018
Member
Author
|
Restored to PR. I'm going to leave the qos stuff since it was in the initial PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.