Merged
Conversation
mlautman
commented
Dec 6, 2018
mlautman
commented
Dec 6, 2018
mlautman
commented
Dec 6, 2018
mlautman
commented
Dec 6, 2018
mlautman
commented
Dec 6, 2018
removing dead code
mlautman
commented
Dec 6, 2018
removing whitespace
brawner
reviewed
Dec 6, 2018
CMakeLists.txt
Outdated
| install( | ||
| TARGETS ${PROJECT_NAME} | ||
| EXPORT ${PROJECT_NAME} | ||
| ARCHIVE DESTINATION lib |
Member
Author
There was a problem hiding this comment.
This is taken from here: https://github.com/ros-visualization/qt_gui_core/blob/00eee66c53fb105b8b55f57b2f01f85902fb4b04/qt_gui_cpp/src/qt_gui_cpp/CMakeLists.txt#L43
I'm not sure what you are suggesting I change. Can you suggest a commit?
There was a problem hiding this comment.
Suggested change
| ARCHIVE DESTINATION lib | |
| ARCHIVE DESTINATION lib/${PROJECT_NAME} |
| @@ -0,0 +1,72 @@ | |||
| #!/usr/bin/env python3 | |||
There was a problem hiding this comment.
Is this file necessary, or was it just used for debugging?
Member
Author
There was a problem hiding this comment.
This is a demo. It is for debugging but it doesn't add any dependencies so I think it is worth keeping
Contributor
|
I don't think we need to embed an image and a script to publish that image into this package. There are existing demo nodes which do exactly that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rqt_image_view ros2 port
Needs ros-visualization/rqt#163 to work
(Lenna)