Merged
Conversation
c5661f0 to
d790dc4
Compare
brawner
reviewed
Nov 20, 2018
be7e45d to
509a5f9
Compare
dirk-thomas
reviewed
Nov 21, 2018
fd50989 to
8191f8a
Compare
8e39066 to
5913f11
Compare
mlautman
commented
Dec 6, 2018
5913f11 to
134724d
Compare
brawner
reviewed
Dec 6, 2018
brawner
reviewed
Dec 6, 2018
9aa9f3b to
74ddc35
Compare
74ddc35 to
3cd254b
Compare
968c637 to
be98c45
Compare
Member
Author
|
All feedback addressed. Merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr ports rqt_gui_cpp to be built with Colcon
I intentionally separated this from porting the plugin providers so that we can get a jump start on the review process. Also, seeing as this is my first cpp port, I wanted to get a second pair of eyes on just the cmake changes