Add a dependency on pytest to rqt_bag and rqt_bag_plugins.#148
Merged
clalancette merged 1 commit intorollingfrom Feb 7, 2024
Merged
Add a dependency on pytest to rqt_bag and rqt_bag_plugins.#148clalancette merged 1 commit intorollingfrom
clalancette merged 1 commit intorollingfrom
Conversation
While there aren't currently any tests, this sets them up to have pytest tests in the future. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
ahcorde
approved these changes
Feb 6, 2024
Contributor
Author
|
CI:
|
clalancette
added a commit
that referenced
this pull request
Feb 10, 2024
)" This reverts commit f0a47cf. The main reason to do this is that on Windows Debug, we don't currently have a Debug wheel for PyQt. Thus these tests always fail on that platform. While the "correct" solution is to build a Windows Debug PyQt wheel, that is a decidedly difficult undertaking. Since we don't have tests to speak of in these packages, avoid the problem for now by just going back to what we were doing before, i.e. using unittest for the tests.
clalancette
added a commit
that referenced
this pull request
Feb 12, 2024
#151) Revert "Add a dependency on pytest to rqt_bag and rqt_bag_plugins. (#148)" This reverts commit f0a47cf. The main reason to do this is that on Windows Debug, we don't currently have a Debug wheel for PyQt. Thus these tests always fail on that platform. While the "correct" solution is to build a Windows Debug PyQt wheel, that is a decidedly difficult undertaking. Since we don't have tests to speak of in these packages, avoid the problem for now by just going back to what we were doing before, i.e. using unittest for the tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While there aren't currently any tests, this sets them up to have pytest tests in the future.