Merged
Conversation
claireyywang
previously approved these changes
Oct 27, 2020
dirk-thomas
previously approved these changes
Oct 27, 2020
Contributor
dirk-thomas
left a comment
There was a problem hiding this comment.
The ROS 2 branch needs a similar patch.
Contributor
|
For CI to pass the name and email needs to be swapped in the XML. |
Previous: @dirk-thomas New: @claireyywang, @sloretz Signed-off-by: Shane Loretz <sloretz@openrobotics.org>
da326d2 to
b565497
Compare
Contributor
Author
Oops, 😶 fixed in b565497 |
dirk-thomas
approved these changes
Oct 28, 2020
sloretz
added a commit
that referenced
this pull request
Oct 29, 2020
Previous: @dirk-thomas New: @claireyywang, @sloretz Signed-off-by: Shane Loretz <sloretz@openrobotics.org>
sloretz
added a commit
that referenced
this pull request
Oct 29, 2020
Previous: @dirk-thomas New: @claireyywang, @sloretz Signed-off-by: Shane Loretz <sloretz@openrobotics.org>
sloretz
added a commit
that referenced
this pull request
Oct 29, 2020
Previous: @dirk-thomas New: @claireyywang, @sloretz Signed-off-by: Shane Loretz <sloretz@openrobotics.org>
sloretz
added a commit
that referenced
this pull request
Oct 29, 2020
Previous: @dirk-thomas New: @claireyywang, @sloretz Signed-off-by: Shane Loretz <sloretz@openrobotics.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous: @dirk-thomas
New: @claireyywang, @sloretz
Signed-off-by: Shane Loretz sloretz@openrobotics.org