Fix #69: use shiboken target over variable#77
Merged
dirk-thomas merged 1 commit intoros-visualization:kinetic-develfrom Oct 24, 2019
Merged
Fix #69: use shiboken target over variable#77dirk-thomas merged 1 commit intoros-visualization:kinetic-develfrom
dirk-thomas merged 1 commit intoros-visualization:kinetic-develfrom
Conversation
Contributor
|
Thanks for the patch. |
dirk-thomas
pushed a commit
that referenced
this pull request
Oct 24, 2019
Contributor
|
Cherry-picked to the |
Contributor
|
Although the variable
|
Contributor
Author
|
@stertingen you're right. I think that splitting the CMake file for shiboken2 >= 5.12.2 and one for the legacy version is the way to go; essentially, the CMake integration is fundamentally different and branching on the version is substantially easier than trying to emulate the legacy variables. I might get a version to work over the next days and will submit a pull request then. |
Contributor
See #78 for a new ticket about those. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #69 and should be downward compatible.