If present, use the sipconfig suggested sip program#70
Merged
dirk-thomas merged 1 commit intoros-visualization:crystal-develfrom Aug 16, 2019
cottsay:patch-1
Merged
If present, use the sipconfig suggested sip program#70dirk-thomas merged 1 commit intoros-visualization:crystal-develfrom cottsay:patch-1
dirk-thomas merged 1 commit intoros-visualization:crystal-develfrom
cottsay:patch-1
Conversation
The value of `SIP_EXECUTABLE` is not used in the sip invocation within `sip_configure.py`. Instead, the `sip_bin` configuration is loaded from the `sipconfig` Python module. Instead of assuming that the sip executable is called `sip` in the CMake which detects whether the sip binding generator is present, try to find the executable in the same way that `sip_configure.py` will. Signed-off-by: Scott K Logan <logans@cottsay.net>
Contributor
|
Thanks for the patch. |
dirk-thomas
pushed a commit
that referenced
this pull request
Sep 30, 2019
The value of `SIP_EXECUTABLE` is not used in the sip invocation within `sip_configure.py`. Instead, the `sip_bin` configuration is loaded from the `sipconfig` Python module. Instead of assuming that the sip executable is called `sip` in the CMake which detects whether the sip binding generator is present, try to find the executable in the same way that `sip_configure.py` will. Signed-off-by: Scott K Logan <logans@cottsay.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The value of
SIP_EXECUTABLEis not used in the sip invocation withinsip_configure.py. Instead, thesip_binconfiguration is loaded from thesipconfigPython module.Instead of assuming that the sip executable is called
sipin the CMake which detects whether the sip binding generator is present, try to find the executable in the same way thatsip_configure.pywill.