Replace Qt variable in generated Makefile.#64
Merged
dirk-thomas merged 2 commits intoros-visualization:kinetic-develfrom Jul 29, 2019
Merged
Replace Qt variable in generated Makefile.#64dirk-thomas merged 2 commits intoros-visualization:kinetic-develfrom
dirk-thomas merged 2 commits intoros-visualization:kinetic-develfrom
Conversation
Contributor
|
Thanks for the patch.
Please create a separate ticket for this separate task. Otherwise it is pretty likely it gets lost once this ticket is closed. Even better would be to consider contributing a pull request 😉 |
dirk-thomas
pushed a commit
that referenced
this pull request
Jul 29, 2019
* Replace Qt variable in generated Makefile. * use single quotes
dirk-thomas
added a commit
that referenced
this pull request
Jul 29, 2019
Closed
dirk-thomas
pushed a commit
that referenced
this pull request
Sep 30, 2019
* Replace Qt variable in generated Makefile. * use single quotes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the
$$[QT_INSTALL_LIBS]variable, introduced in Qt 5.12.4.For more info, check here.
Note: sipconfig will be unsupported in sip5, so maybe someone should spend time on replacing sipconfig with something else that is not deprecated?