Don't add -l prefix if it already exists.#59
Merged
dirk-thomas merged 1 commit intoros-visualization:kinetic-develfrom Jan 2, 2019
Merged
Don't add -l prefix if it already exists.#59dirk-thomas merged 1 commit intoros-visualization:kinetic-develfrom
dirk-thomas merged 1 commit intoros-visualization:kinetic-develfrom
Conversation
brawner
reviewed
Dec 20, 2018
Contributor
brawner
left a comment
There was a problem hiding this comment.
Super annoying issue, but just add a short comment echoing what you are saying in this PR.
|
|
||
| def custom_platform_lib_function(self, clib, framework=0): | ||
| if os.path.isabs(clib): | ||
| if os.path.isabs(clib) or clib.startswith('-l'): |
Contributor
There was a problem hiding this comment.
Please add a comment describing why this check is necessary and libraries that already append -l
943e8a0 to
e4eed9b
Compare
Contributor
Author
|
Apologies for the delay, holidays and everything. I just pushed the requested change. |
Contributor
|
Thanks for the patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similarly as discussed here, a
-lshouldn't be prefixed if a library already has a-lprefix. Recently (cmake 3.13) exported its dependency on pthread by adding-lpthreadto${Boost_LIBRARIES}. Using thesip_helper.pyon cmake 3.13 gives the following error: