Merged
Conversation
brawner
reviewed
Oct 17, 2018
| if str(type(widget)).find(self.class_aliases.get(class_name, class_name)) < 0: | ||
| sys.modules['QtCore'].qDebug(str('PySide.loadUi(): could not find widget class "%s", defaulting to "%s"' % (class_name, type(widget)))) | ||
| sys.modules['QtCore'].qDebug( | ||
| str('PySide.loadUi(): could not find widget class "%s", defaulting to "%s"' % (class_name, type(widget)))) |
Contributor
There was a problem hiding this comment.
This doesn't need to be converted to a string right?
dirk-thomas
reviewed
Oct 18, 2018
|
|
||
| if not QT_BINDING: | ||
| raise ImportError("Could not find Qt binding (looked for: %s):\n%s" % (', '.join(["'%s'" % b for b in binding_order]), '\n'.join(error_msgs))) | ||
| raise ImportError("Could not find Qt binding (looked for: %s):\n%s" % |
Contributor
There was a problem hiding this comment.
We prefer to wrap after the open parenthesis in order to make the following line "unaligned" and not depend on the content before the parenthesis, e.g.:
raise ImportError(
"Could not find Qt binding (looked for: %s):\n%s" %
(', '.join(["'%s'" % b for b in binding_order]), '\n'.join(error_msgs)))
dirk-thomas
approved these changes
Oct 19, 2018
dirk-thomas
reviewed
Oct 19, 2018
| #loader = CustomUiLoader(baseinstance) | ||
| #custom_widgets = custom_widgets or {} | ||
| #for custom_widget in custom_widgets.values(): | ||
| # for custom_widget in custom_widgets.values(): |
Contributor
There was a problem hiding this comment.
I was wondering why only this line was affected but not the two lines above?
Member
Author
There was a problem hiding this comment.
I'm really not sure about the internals of autopep8. It seems to consistently do about 95% of what you would hope it would do
mlautman
added a commit
that referenced
this pull request
Oct 20, 2018
* autopep8 * wrap * autopep8 fixup
mlautman
pushed a commit
that referenced
this pull request
Oct 26, 2018
* Modifying files for ros2 * Moving .cmake.em to .cmake * Removing QtBindingHelper * autopep8 * Adding tests * autopep8 (#51) * autopep8 * wrap * autopep8 fixup * Adding tests * Reverting copyright * Updating package.xml * Cleaning up * Updating package.xml * Cmakelists * package.xml * tests working again * package.xml * package.xml * package.xml * package.xml * package.xml * package.xml * package.xml * package.xml * cmakelists * Updating cmake files to work with qt_gui_cpp * Building and installing * Reverting to original imports * Pass flake8 * Removing install * Moving python files back to src * Addressing pull request * Addressing pull request comments * Cleaning up * one import per line * Addressing pull request comments * comment case only
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Results of running
autopep8 --max-line-length 130 --in-place $1on each.pyfile