various updates for making it standalone#5
Conversation
There was a problem hiding this comment.
I think including package.xml may be required here (otherwise the sdist won't have it at the time setup.py wants to read it). You probably also want the Makefile at the root level.
There was a problem hiding this comment.
package.xml +1
But why the Makefile? It only contains deploy information which won't be helpful for anybody else.
There was a problem hiding this comment.
I'm not sure; I only know the setup.py parts. If you include everything here, you can host a sdist package that is more or less a copy of your repository on pypi. Then you can use your cmake / makefile without doing a git checkout (or however you normally distribute this)
|
I did some very light testing; setup.py works and I can correctly import PySide through the binding. I'll update on Monday with a more thorough test. |
|
Great, thank you for taking the time and testing it. |
|
I converted my PyQt4 application to python_qt_binding, and it works well. I think this branch is stable to merge back into master, and encourage you to submit this to pypi. |
|
Thanks for checking it. I will do the release to PyPI as soon as the next patch release is done (likely within a week). |
various updates for making it standalone
cleanup cmake
update Python to allow overriding binding order
enable setup.py to work without catkin_pkg
add MANIFEST / Makefile to deploy standalone Python package via PyPI