Remove :: from shiboken include path#48
Merged
dirk-thomas merged 1 commit intoros-visualization:kinetic-develfrom Sep 7, 2018
Merged
Remove :: from shiboken include path#48dirk-thomas merged 1 commit intoros-visualization:kinetic-develfrom
dirk-thomas merged 1 commit intoros-visualization:kinetic-develfrom
Conversation
The Variable QT_INCLUDE_DIR_WITH_COLONS is iteratively generated
starting with an empty string and adding :${dir}. This always results in
a colon as the first symbol. When combining it with the INCLUDE_PATH
adding a second colon results in :: in the string. The shiboken command
line utility currently has a bug generating an invalid command out of
this (-I without a string). This seems to have been fixed in the
development version already. Still this double colon ins superfluous so
let's remove it.
Contributor
|
Thanks for the fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Variable QT_INCLUDE_DIR_WITH_COLONS is iteratively generated
starting with an empty string and adding :${dir}. This always results in
a colon as the first symbol. When combining it with the INCLUDE_PATH
adding a second colon results in :: in the string. The shiboken command
line utility currently has a bug generating an invalid command out of
this (-I without a string). This seems to have been fixed in the
development version already. Still this double colon ins superfluous so
let's remove it.