Skip to content

Suppress warning from Shiboken2.#137

Merged
ahcorde merged 1 commit intorollingfrom
clalancette/suppress-warning
Apr 24, 2024
Merged

Suppress warning from Shiboken2.#137
ahcorde merged 1 commit intorollingfrom
clalancette/suppress-warning

Conversation

@clalancette
Copy link
Copy Markdown
Contributor

@clalancette clalancette commented Apr 23, 2024 •
edited
Loading

The comment has more information on why we are doing this.

Fixes ros-visualization/qt_gui_core#291

@clalancette
Suppress warning from Shiboken2.
2cf82ba 
The comment has more information on why we are doing this.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
@clalancette clalancette requested a review from sloretz as a code owner April 23, 2024 14:20
@clalancette
Copy link
Copy Markdown
Contributor Author

clalancette commented Apr 24, 2024

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit e6b881e into rolling Apr 24, 2024
@ahcorde
Copy link
Copy Markdown
Contributor

ahcorde commented Apr 24, 2024

https://github.com/Mergifyio backport jazzy

@mergify
Copy link
Copy Markdown

mergify bot commented Apr 24, 2024 •
edited
Loading

backport jazzy

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request Apr 24, 2024
@clalancette @mergify
Suppress warning from Shiboken2. (#137)
8fcd177 
The comment has more information on why we are doing this.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit e6b881e)
@mergify mergify bot mentioned this pull request Apr 24, 2024
Merged
@ahcorde ahcorde deleted the clalancette/suppress-warning branch April 24, 2024 20:58
@ahcorde ahcorde mentioned this pull request Apr 25, 2024
Merged
@mergify mergify bot mentioned this pull request Apr 25, 2024
Closed
ahcorde added a commit that referenced this pull request Apr 25, 2024
@mergify @clalancette @ahcorde
Suppress warning from Shiboken2. (backport #137) (#138)
65e3a1d 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@Crola1702
Copy link
Copy Markdown
Contributor

Crola1702 commented Apr 25, 2024

I'm seeing in RHEL Debug, repeated and packaging:

--- stderr: qt_gui_cpp
00:12:27.703 CMake Error at /home/jenkins-agent/workspace/nightly_linux-rhel_debug/ws/install/python_qt_binding/share/python_qt_binding/cmake/shiboken_helper.cmake:27 (cmake_policy):
00:12:27.703   Policy "CMP0148" is not known to this version of CMake.
00:12:27.703 Call Stack (most recent call first):
00:12:27.703   src/qt_gui_cpp_shiboken/CMakeLists.txt:43 (include)

@ahcorde
Copy link
Copy Markdown
Contributor

ahcorde commented Apr 25, 2024

@Crola1702 This PR #139 fixed the issue

@Crola1702
Copy link
Copy Markdown
Contributor

Crola1702 commented Apr 25, 2024

Makes sense. Just noticed that the build was run 9h ago. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahcorde ahcorde ahcorde approved these changes

@sloretz sloretz Awaiting requested review from sloretz

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

🧑‍🌾 CMake warning in Rolling Debug (Policy CMP0148)

3 participants

@clalancette @ahcorde @Crola1702