Remove pyqt from default binding order for macOS#118
Merged
mjcarroll merged 1 commit intoros-visualization:rollingfrom Mar 1, 2023
Merged
Remove pyqt from default binding order for macOS#118mjcarroll merged 1 commit intoros-visualization:rollingfrom
mjcarroll merged 1 commit intoros-visualization:rollingfrom
Conversation
- Suppress debug messages - Remove pyqt from default binding order Signed-off-by: Rhys Mainwaring <rhys.mainwaring@me.com>
This was referenced Sep 2, 2022
mjcarroll
approved these changes
Mar 1, 2023
Member
|
EDIT: Scratch that, something else caused the regression. Still investigating... |
This should be updated to export CMAKE_PREFIX_PATH=/path/to/pyside@2:$CMAKE_PREFIX_PATH
export PATH=/path/to/pyside@2/bin:$PATH
export PYTHONPATH=$PYTHONPATH:/path/to/pyside@2/lib/python3.10/site-packages |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes
pyqtfrom the list of default bindings when running macOS ('Darwin').Partial fix for #103. Details in #103 (comment) for accompanying changes required in https://github.com/ros-visualization/qt_gui_core.
The brew formula for
pyside@2is keg only, to build and run using PySide2 set the environment variables: