Remove explicit template parameter in spin_until_future_complete#72
Merged
jacobperron merged 2 commits intoros-visualization:ros2from Jun 9, 2020
Merged
Remove explicit template parameter in spin_until_future_complete#72jacobperron merged 2 commits intoros-visualization:ros2from
spin_until_future_complete#72jacobperron merged 2 commits intoros-visualization:ros2from
Conversation
Signed-off-by: Sarthak Mittal <sarthakmittal2608@gmail.com>
ivanpauno
reviewed
Jun 9, 2020
Signed-off-by: Sarthak Mittal <sarthakmittal2608@gmail.com>
spin_until_future_received
Contributor
|
@jacobperron I don't have enough powers in this repo to merge. |
jacobperron
approved these changes
Jun 9, 2020
Contributor
jacobperron
left a comment
There was a problem hiding this comment.
- Linux
- Linux-aarch64
- macOS
- Windows
LGTM (pending CI), thanks!
spin_until_future_receivedspin_until_future_complete
jacobperron
pushed a commit
that referenced
this pull request
Jun 9, 2020
* Fix interactive marker server test Signed-off-by: Sarthak Mittal <sarthakmittal2608@gmail.com> * Remove explicit template specialization Signed-off-by: Sarthak Mittal <sarthakmittal2608@gmail.com>
jacobperron
added a commit
that referenced
this pull request
Jun 23, 2020
…) (#73) * Fix interactive marker server test Signed-off-by: Sarthak Mittal <sarthakmittal2608@gmail.com> * Remove explicit template specialization Signed-off-by: Sarthak Mittal <sarthakmittal2608@gmail.com> Co-authored-by: Sarthak Mittal <sarthakmittal2608@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sarthak Mittal sarthakmittal2608@gmail.com
As per ros2/rclcpp#972 and ros2/rclcpp#1113,
spin_until_future_completeshould be able to accept bothstd::futureandstd::shared_future. This is the only downstream error blocking the original PR, I believe making the fix here is a better option.