Remove tinyxml from macOS installations#821
Conversation
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
|
Oh, I just looked at the macOS source build instructions for ROS 2 Humble: https://docs.ros.org/en/humble/Installation/Alternatives/macOS-Development-Setup.html#install-prerequisites. It install tinyxml from a custom formula: |
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
|
Looks like osrf/simulation/tinyxml1 requires an old version of CMake and brew now installs CMake version 4.0.2, so the build fails. Let's try to use an older version of the formula to install version 3.31.1 (https://stackoverflow.com/a/58148648), which is the version mentioned in REP 2000 for Kilted on macOS. It should work for this. |
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #821 +/- ##
==========================================
+ Coverage 93.38% 93.48% +0.10%
==========================================
Files 10 10
Lines 257 261 +4
Branches 27 27
==========================================
+ Hits 240 244 +4
Misses 17 17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Ah, osrf/simulation/tinyxml1 depends on CMake and it pulls in CMake 4. Anyway, I'll just remove tinyxml. |
|
Thanks for the review. I'll wait for a confirmation (#820) before merging. |
|
Released as |
Fixes #820
tinyxml is no longer available from brew: https://formulae.brew.sh/formula/tinyxml
It's no longer needed starting from ROS 2 Jazzy:
We're still supporting Humble, which still depends on tinyxml. Since it's no longer available from brew, I can't (easily) do anything about it.