Closed
Conversation
Member
henningkayser
left a comment
There was a problem hiding this comment.
Shouldn't the namespace be handled by moveit_configs_utils? @JafarAbdi ?
Member
Author
|
But this package doesn't use moveit_configs_utils yet... |
6 tasks
Member
|
Replaced by #119 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the namespace to these parameters so they're loaded properly. You can see that the namespace is needed here:
https://github.com/ros-planning/moveit2/blob/d59a46372c5a3c088a61732f5c8f152f67778c34/moveit_ros/planning/robot_model_loader/src/robot_model_loader.cpp#L124
joint_limits.yaml is optional. It overrides values in the URDF in case you want custom limits for your robot. It also allows a jerk limit to be specified, which you cannot do from the URDF.
Fixes #122