Deprecating tf2 C Headers#469
Merged
SteveMacenski merged 1 commit intoros-perception:ros2from Jan 2, 2025
Merged
Conversation
Signed-off-by: CursedRock17 <mtglucas1@gmail.com>
Contributor
|
I think if we want to do this, we should create backwards compatibilty headers that emit compile warnings so users have time to migrate to the new headers. Let's see first if the PR on geometry2 is going to be merged. |
Contributor
Yes, that is exactly what ros2/geometry2#720 does. This PR is just a preemptive one (thanks @CursedRock17 ) to avoid the warnings once we merge that PR in. |
Contributor
Author
|
With the recent backports merged, this PR should be good for review. |
Member
|
Toggling for CI |
Member
|
@CursedRock17 can you open for message filters? That is causing build warnings here since that isn't updated as well (but not blocking) |
AntoBrandi
pushed a commit
to AntoBrandi/perception_pcl
that referenced
this pull request
Aug 26, 2025
Signed-off-by: CursedRock17 <mtglucas1@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to this pull request in
geometry2in which we deprecated the.hstyle headers in favor of.hpp.