Skip to content

Add support for CreateTimerInterface - fix CI#946

Merged
4 commits merged intomasterfrom
unknown repository
Jul 19, 2019
Merged

Add support for CreateTimerInterface - fix CI#946
4 commits merged intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Jul 18, 2019 •
edited by ghost
Loading

Basic Info

Info Please fill out this column
Ticket(s) this addresses fixes #941
Primary OS tested on Ubuntu
Robotic platform tested on TB3 in Gazebo

Description of contribution in a few bullet points

  1. Makes use of the new CreateTimerInterface API in TF Buffer.
  2. Reenables TF listener to create it's own node and thread. I don't know why this is necessary, but it seems like the right thing to do anyhow. Without this change we seem to end up with more transform errors.
  3. Fixes a bug in the system test launch file introduced in change primitives to recoveries #705

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 18, 2019

Codecov Report

Merging #946 into master will increase coverage by 1.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #946      +/-   ##
==========================================
+ Coverage   29.72%   30.91%   +1.18%     
==========================================
  Files         191      236      +45     
  Lines        9941    10652     +711     
  Branches     3279     3988     +709     
==========================================
+ Hits         2955     3293     +338     
- Misses       5173     5308     +135     
- Partials     1813     2051     +238
Impacted Files Coverage Δ
..._voxel_grid/include/nav2_voxel_grid/voxel_grid.hpp 52.75% <0%> (-12.94%) ⬇️
...map_2d/include/nav2_costmap_2d/layered_costmap.hpp 57.14% <0%> (-9.53%) ⬇️
...vigation2/nav2_costmap_2d/plugins/static_layer.cpp 32.89% <0%> (-3.78%) ⬇️
...map_2d/test/integration/test_collision_checker.cpp 53.84% <0%> (-0.06%) ⬇️
...ontroller/dwb_core/include/dwb_core/exceptions.hpp 0% <0%> (ø) ⬆️
...er/dwb_core/include/dwb_core/trajectory_critic.hpp 0% <0%> (ø) ⬆️
...tmap_2d/include/nav2_costmap_2d/costmap_2d_ros.hpp 0% <0%> (ø) ⬆️
...r/nav_2d_utils/include/nav_2d_utils/parameters.hpp 0% <0%> (ø)
...generator_cpp/nav2_msgs/action/back_up__struct.hpp 0% <0%> (ø)
..._generator_cpp/nav_2d_msgs/msg/path2_d__struct.hpp 0% <0%> (ø)
... and 68 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aaa8c2e...1d4603d. Read the comment docs.

@ghost ghost changed the title [WIP] Add support for CreateTimerInterface - fix CI Add support for CreateTimerInterface - fix CI Jul 18, 2019
@ghost ghost added the 0 - Critical Critical to project, highest priority label Jul 18, 2019
@ghost ghost merged commit 640ec41 into ros-navigation:master Jul 19, 2019
@mlherd mlherd mentioned this pull request Jul 21, 2019
Closed
Forsyth-Creations pushed a commit to Forsyth-Creations/navigation2 that referenced this pull request Feb 19, 2025
@christophfroehlich
Do not run reviewer lottery for dependabot and mergify (ros-navigatio…
3c3f614 
…n#946)
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

0 - Critical Critical to project, highest priority

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Nav2 system tests broken

1 participant

@orduno