Update costmap on new computePathToPose#796
Merged
bpwilcox merged 2 commits intoros-navigation:lifecyclefrom Jun 4, 2019
Merged
Update costmap on new computePathToPose#796bpwilcox merged 2 commits intoros-navigation:lifecyclefrom
bpwilcox merged 2 commits intoros-navigation:lifecyclefrom
Conversation
mjeronimo
approved these changes
Jun 1, 2019
orduno
suggested changes
Jun 3, 2019
Contributor
orduno
left a comment
There was a problem hiding this comment.
Thanks for the change, totally overlooked this issue.
We need to add a check, see below.
ghost
suggested changes
Jun 3, 2019
added 2 commits
June 3, 2019 12:06
check and resize planner costmap array clean up
50ab69a to
1bf6593
Compare
ghost
approved these changes
Jun 4, 2019
orduno
approved these changes
Jun 4, 2019
Forsyth-Creations
pushed a commit
to Forsyth-Creations/navigation2
that referenced
this pull request
Feb 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an apparent oversight where the navfn_planner doesn't update its costmap when given a new
computePathToPoseaction, which previously caused failures when attempting to navigate to areas that were considered illegal from the initial costmap it received.