Add the rviz panel and action-based goal tool#663
Merged
mjeronimo merged 6 commits intoros-navigation:lifecyclefrom May 7, 2019
mjeronimo:nav2-rviz-plugins
Merged
Add the rviz panel and action-based goal tool#663mjeronimo merged 6 commits intoros-navigation:lifecyclefrom mjeronimo:nav2-rviz-plugins
mjeronimo merged 6 commits intoros-navigation:lifecyclefrom
mjeronimo:nav2-rviz-plugins
Conversation
mkhansenbot
reviewed
May 6, 2019
Collaborator
mkhansenbot
left a comment
There was a problem hiding this comment.
Looks good, I had a couple minor suggestions and a non-gating question about whether we still support the move_base_simple/goal topic. I think we need to. That's not really part of this PR but came to mind when reading it so we can discuss separately.
nav2_rviz_plugins/include/nav2_rviz_plugins/navigation_dialog.hpp
Outdated
Show resolved
Hide resolved
SteveMacenski
approved these changes
May 7, 2019
mjeronimo
pushed a commit
that referenced
this pull request
May 22, 2019
* Add the rviz panel and action-based goal tool * Remove the non-button stuff in the nav2_panel (it will go into rqt instead) * Use setRPY and toMsg instead of computing x,y,z,w * Address some review feedback * Fix a typo * Address one more item from the code review
mjeronimo
pushed a commit
that referenced
this pull request
Jun 6, 2019
* Add the rviz panel and action-based goal tool * Remove the non-button stuff in the nav2_panel (it will go into rqt instead) * Use setRPY and toMsg instead of computing x,y,z,w * Address some review feedback * Fix a typo * Address one more item from the code review
ghost
pushed a commit
that referenced
this pull request
Jun 10, 2019
* Add the rviz panel and action-based goal tool * Remove the non-button stuff in the nav2_panel (it will go into rqt instead) * Use setRPY and toMsg instead of computing x,y,z,w * Address some review feedback * Fix a typo * Address one more item from the code review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Future work