Skip to content

Backport docking in reverse fixes for jazzy#5971

Merged
SteveMacenski merged 3 commits intoros-navigation:jazzyfrom
icpmoles:sync_jazzy
Feb 19, 2026
Merged

Backport docking in reverse fixes for jazzy#5971
SteveMacenski merged 3 commits intoros-navigation:jazzyfrom
icpmoles:sync_jazzy

Conversation

@icpmoles
Copy link

Basic Info

Info Please fill out this column
Ticket(s) this addresses
Primary OS tested on Ubuntu
Robotic platform tested on tb{3|4}_simulation loopback & gazebo + simulation in custom world in gazebo + physical robot
Does this PR contain AI generated software? No
Was this PR description generated by AI software? No

Description of contribution in a few bullet points

Manual backporting of #5097 for jazzy, fixing #5970.

Some tests were dropped because the targeted features were not available in this branch

Description of documentation updates required from your changes

N.A.

Description of how this change was tested

  • functional tests as described in the docs:
    • colcon test.
    • running all 4 simulations for 5 minutes each.
    • test with my own simulation on gazebo.
    • tests on real platform to validate.

Future work that may be required in bullet points

N/A

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists
  • Should this be backported to current distributions? If so, tag with backport-*.

ajtudela and others added 2 commits February 18, 2026 22:02
…os-navigation#5097)

* Increase docking coverage && fix backward docking (backport Jazzy)

Signed-off-by: Iacopo Moles <iacopo@icpmol.es>

Increase docking coverage && fix backward docking (ros-navigation#5097)

* Add dock_database tests

Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

* Add utils test

Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

* Improve filter tests

Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

* Added simple charging tests

Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

* Improve comments

Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

* Fix backward and redo main test

Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

* Change test period to reduce test time

Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

* Revert "Change test period to reduce test time"

This reverts commit ef1555e.

Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

* Delete print pose

Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

---------

Signed-off-by: Alberto Tudela <ajtudela@gmail.com>
Signed-off-by: Iacopo Moles <iacopo@icpmol.es>
Signed-off-by: Iacopo Moles <iacopo@icpmol.es>
@mergify
Copy link
Contributor

mergify bot commented Feb 18, 2026

@icpmoles, all pull requests must be targeted towards the main development branch.
Once merged into main, it is possible to backport to @jazzy, but it must be in main
to have these changes reflected into new distributions.

@codecov
Copy link

codecov bot commented Feb 18, 2026

Codecov Report

❌ Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...av2_docking/opennav_docking/src/docking_server.cpp 50.00% 2 Missing ⚠️
Files with missing lines Coverage Δ
nav2_docking/opennav_docking/src/dock_database.cpp 100.00% <100.00%> (+10.00%) ⬆️
...av2_docking/opennav_docking/src/docking_server.cpp 89.23% <50.00%> (+0.05%) ⬆️

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

<package format="3">
<name>nav2_amcl</name>
<version>1.3.11</version>
<version>1.3.12</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert all of these

@SteveMacenski SteveMacenski changed the title Sync jazzy Backport docking in reverse fixes for jazzy Feb 18, 2026
This reverts commit a35c23d.

Signed-off-by: Iacopo Moles <iacopo@icpmol.es>
@SteveMacenski SteveMacenski merged commit d9e70fb into ros-navigation:jazzy Feb 19, 2026
10 of 11 checks passed
redvinaa pushed a commit to EnjoyRobotics/navigation2 that referenced this pull request Mar 2, 2026
* Increase docking coverage && fix backward docking (backport Jazzy) (ros-navigation#5097)

* Increase docking coverage && fix backward docking (backport Jazzy)

Signed-off-by: Iacopo Moles <iacopo@icpmol.es>

Increase docking coverage && fix backward docking (ros-navigation#5097)

* Add dock_database tests

Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

* Add utils test

Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

* Improve filter tests

Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

* Added simple charging tests

Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

* Improve comments

Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

* Fix backward and redo main test

Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

* Change test period to reduce test time

Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

* Revert "Change test period to reduce test time"

This reverts commit ef1555e.

Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

* Delete print pose

Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

---------

Signed-off-by: Alberto Tudela <ajtudela@gmail.com>
Signed-off-by: Iacopo Moles <iacopo@icpmol.es>

* bump package versions

Signed-off-by: Iacopo Moles <iacopo@icpmol.es>

* Revert "bump package versions"

This reverts commit a35c23d.

Signed-off-by: Iacopo Moles <iacopo@icpmol.es>

---------

Signed-off-by: Alberto Tudela <ajtudela@gmail.com>
Signed-off-by: Iacopo Moles <iacopo@icpmol.es>
Co-authored-by: Alberto Tudela <ajtudela@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants