Skip to content

Migrating parameter APIs for Map Server, DWB, and Opennav Following: Completed Process#5914

Merged
SteveMacenski merged 14 commits intomainfrom
param_api_migration2
Jan 28, 2026
Merged

Migrating parameter APIs for Map Server, DWB, and Opennav Following: Completed Process#5914
SteveMacenski merged 14 commits intomainfrom
param_api_migration2

Conversation

@SteveMacenski
Copy link
Member

@SteveMacenski SteveMacenski commented Jan 28, 2026

Per #5299

@mini-1235 please review as well

@SteveMacenski
Migrate Nav2 Docking to use new Parameter API
d2c311c 
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
@SteveMacenski
Migrating lifecycle manager to use new parameters API
40d5aa1 
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
@SteveMacenski
Migrate nav2 util to use new parameter API
6e28d6d 
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
@SteveMacenski
Migrate Theta* to new parameters API
ebb960a 
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
@SteveMacenski
Migrating nav2 smoother to new parameters API
8cf1fc2 
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
@SteveMacenski
migrate nav2 planner to use new parameters API
0a941c8 
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
@SteveMacenski
migate velocity smoother to new API
96208ca 
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
@SteveMacenski
testing working again
31436c5 
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
@SteveMacenski
Fixing system tests
a9707f5 
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
@SteveMacenski
Migrate smac planner too
74cca16 
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
@SteveMacenski
Migrate DWB, Following, and Map Server
5df92a8 
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
@SteveMacenski SteveMacenski linked an issue Jan 28, 2026 that may be closed by this pull request
Update declares and gets to use new declare_or_get_param API #5299
Closed
@SteveMacenski
Adding a missed few
d1e45a7 
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
@SteveMacenski
typo
95e798e 
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
@SteveMacenski SteveMacenski changed the title Migrating parameter APIs for Map Server, DWB, and Opennav Following Migrating parameter APIs for Map Server, DWB, and Opennav Following: Completed Process Jan 28, 2026
@SteveMacenski
Copy link
Member Author

SteveMacenski commented Jan 28, 2026

Done. Also added a few stragglers that folks missed

@SteveMacenski SteveMacenski mentioned this pull request Jan 28, 2026
Closed
8 tasks
@codecov
Copy link

codecov bot commented Jan 28, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
...er/dwb_core/include/dwb_core/trajectory_critic.hpp 93.33% <100.00%> (-1.12%) ⬇️
..._dwb_controller/dwb_core/src/dwb_local_planner.cpp 76.25% <100.00%> (-1.92%) ⬇️
nav2_dwb_controller/dwb_core/src/publisher.cpp 67.14% <100.00%> (-2.40%) ⬇️
...2_dwb_controller/dwb_critics/src/base_obstacle.cpp 96.77% <100.00%> (-0.11%) ⬇️
nav2_dwb_controller/dwb_critics/src/map_grid.cpp 71.42% <100.00%> (-0.88%) ⬇️
...av2_dwb_controller/dwb_critics/src/oscillation.cpp 73.97% <100.00%> (-0.36%) ⬇️
..._dwb_controller/dwb_critics/src/prefer_forward.cpp 94.44% <100.00%> (-1.39%) ⬇️
...ontroller/dwb_plugins/src/kinematic_parameters.cpp 100.00% <100.00%> (ø)
...roller/dwb_plugins/src/limited_accel_generator.cpp 100.00% <100.00%> (ø)
...roller/dwb_plugins/src/standard_traj_generator.cpp 97.67% <100.00%> (-0.18%) ⬇️
... and 9 more

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SteveMacenski SteveMacenski merged commit f3ea4f1 into main Jan 28, 2026
16 checks passed
@mergify mergify bot deleted the param_api_migration2 branch January 28, 2026 21:18
Pana1v pushed a commit to Arnav-panjla/navigation2 that referenced this pull request Feb 21, 2026
@SteveMacenski
Migrating parameter APIs for Map Server, DWB, and Opennav Following: …
71a9e7d 
…Completed Process (ros-navigation#5914)

* Migrate Nav2 Docking to use new Parameter API

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Migrating lifecycle manager to use new parameters API

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Migrate nav2 util to use new parameter API

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Migrate Theta* to new parameters API

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Migrating nav2 smoother to new parameters API

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* migrate nav2 planner to use new parameters API

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* migate velocity smoother to new API

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* testing working again

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Fixing system tests

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Migrate smac planner too

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Migrate DWB, Following, and Map Server

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Adding a missed few

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* typo

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

---------

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mini-1235 mini-1235 mini-1235 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update declares and gets to use new declare_or_get_param API

2 participants

@SteveMacenski @mini-1235