Fix bt navigator feedback in looping path#5864
Merged
SteveMacenski merged 12 commits intoros-navigation:mainfrom Jan 15, 2026
Merged
Fix bt navigator feedback in looping path#5864SteveMacenski merged 12 commits intoros-navigation:mainfrom
SteveMacenski merged 12 commits intoros-navigation:mainfrom
Conversation
8 tasks
mini-1235
commented
Jan 14, 2026
mini-1235
commented
Jan 14, 2026
| syncTabsWithAccumulatedPoses(); // Sync tabs with new pose | ||
| } else { | ||
| acummulated_poses_ = nav_msgs::msg::Goals(); | ||
| // Reset goal index for single goal navigation |
Collaborator
Author
There was a problem hiding this comment.
There are some issues with the rviz panel when doing single goal navigation:
- The goal index is not reset after using waypoint follower
- The goal is not added to store poses
However, I am not sure if this is the best place to add these
Member
There was a problem hiding this comment.
Got it - I default to your judgement on this
Collaborator
Author
There was a problem hiding this comment.
Sorry, it seems that this introduced a minor bug, will open a PR tomorrow
Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: Maurice Alexander Purnawan <mauricepurnawan@gmail.com>
Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: Maurice Alexander Purnawan <mauricepurnawan@gmail.com>
Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
Signed-off-by: Maurice <mauricepurnawan@gmail.com>
| return first_after_constraint; | ||
| } | ||
|
|
||
| bool isPathUpdated( |
Member
There was a problem hiding this comment.
Add a test for this plz
Otherwise this PR looks good to me. I merged the docs as well
Collaborator
Author
There was a problem hiding this comment.
Added, waiting for the ci to run again
Member
|
Check uncrustify ;-) |
Collaborator
Author
|
Always forgot to lint before I commit 😓 |
SteveMacenski
approved these changes
Jan 15, 2026
Lotusymt
pushed a commit
to Lotusymt/navigation2
that referenced
this pull request
Jan 16, 2026
* Fix bt navigator feedback in looping path Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Revert Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Revert Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Lint Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Update nav2_bt_navigator/src/navigators/navigate_to_pose.cpp Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: Maurice Alexander Purnawan <mauricepurnawan@gmail.com> * Update nav2_bt_navigator/src/navigators/navigate_through_poses.cpp Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: Maurice Alexander Purnawan <mauricepurnawan@gmail.com> * Add tracking error to Navigators feedback Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Lint Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Lint Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Add search window to bringup Signed-off-by: Maurice <mauricepurnawan@gmail.com> * Add test Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Lint Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> --------- Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> Signed-off-by: Maurice Alexander Purnawan <mauricepurnawan@gmail.com> Signed-off-by: Maurice <mauricepurnawan@gmail.com> Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: lotusymt <mengtiy5@uci.edu>
8 tasks
Pana1v
pushed a commit
to Arnav-panjla/navigation2
that referenced
this pull request
Feb 21, 2026
* Fix bt navigator feedback in looping path Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Revert Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Revert Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Lint Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Update nav2_bt_navigator/src/navigators/navigate_to_pose.cpp Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: Maurice Alexander Purnawan <mauricepurnawan@gmail.com> * Update nav2_bt_navigator/src/navigators/navigate_through_poses.cpp Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: Maurice Alexander Purnawan <mauricepurnawan@gmail.com> * Add tracking error to Navigators feedback Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Lint Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Lint Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Add search window to bringup Signed-off-by: Maurice <mauricepurnawan@gmail.com> * Add test Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Lint Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> --------- Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> Signed-off-by: Maurice Alexander Purnawan <mauricepurnawan@gmail.com> Signed-off-by: Maurice <mauricepurnawan@gmail.com> Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
Description of documentation updates required from your changes
Description of how this change was tested
Future work that may be required in bullet points
For Maintainers:
backport-*.