[Collision Monitor] fix Z base frame transformation (backport #5794)#5815
Merged
SteveMacenski merged 1 commit intojazzyfrom Dec 25, 2025
Merged
[Collision Monitor] fix Z base frame transformation (backport #5794)#5815SteveMacenski merged 1 commit intojazzyfrom
SteveMacenski merged 1 commit intojazzyfrom
Conversation
Signed-off-by: Guillaume Doisy <guillaume@dexory.com> Co-authored-by: Guillaume Doisy <guillaume@dexory.com> (cherry picked from commit 4534ff1)
Contributor
Author
SteveMacenski
approved these changes
Dec 25, 2025
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
min_height/max_heightapplied to a pointcloud source in the CM is not anymore relative tobase_frame_idbut relative to the frame_id of that source when not usinguse_global_height.Can be quite critical as impacting which part of a pointcloud are used in the collision monitor/detector.
I believe since: #5586
Draft to get the info out asap but not yet 100% checked. Will need extra sanity checks.
This is an automatic backport of pull request #5794 done by Mergify.