Skip to content

Added fixes for ament_mypy#5382

Merged
SteveMacenski merged 1 commit intoros-navigation:mainfrom
leander-dsouza:fix_ament_mypy
Jul 23, 2025
Merged

Added fixes for ament_mypy#5382
SteveMacenski merged 1 commit intoros-navigation:mainfrom
leander-dsouza:fix_ament_mypy

Conversation

@leander-dsouza
Copy link
Contributor


Basic Info

Info Please fill out this column
Ticket(s) this addresses #5370
Primary OS tested on Ubuntu
Robotic platform tested on N/A
Does this PR contain AI-generated software? No

Description of contribution in a few bullet points

  • Migrated RcutilsLogger to use warning instead of warn as a member.
  • Removed redundant attr-defined mypy comments.

Description of documentation updates required from your changes

  • N/A

Description of how this change was tested

  • Ran local pre-commits before publishing.

Future work that may be required in bullet points

  • N/A

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists
  • Should this be backported to current distributions? If so, tag with backport-*.

Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
@codecov
Copy link

codecov bot commented Jul 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

see 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@leander-dsouza leander-dsouza marked this pull request as ready for review July 22, 2025 23:50
@SteveMacenski SteveMacenski merged commit d58606a into ros-navigation:main Jul 23, 2025
16 checks passed
SakshayMahna pushed a commit to SakshayMahna/navigation2 that referenced this pull request Aug 8, 2025
Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants