Dynamic reconfigure CM pointcloud min_height and max_height#5366
Merged
SteveMacenski merged 3 commits intoros-navigation:mainfrom Jul 18, 2025
Merged
Conversation
SteveMacenski
approved these changes
Jul 17, 2025
Contributor
|
@kaichie, your PR has failed to build. Please check CI outputs and resolve issues. |
Member
|
@kaichie rebase or pull in main. There's been some major ABI breaking changes from ROS core that we have now fixed that should make this turn over. |
Contributor
Author
|
@SteveMacenski We need to double check a few thing before ready for review. (Will rebased and ping when ready) |
Signed-off-by: nelson <kaichie.lee@gmail.com>
Signed-off-by: nelson <kaichie.lee@gmail.com>
Signed-off-by: nelson <kaichie.lee@gmail.com>
24588a0 to
f0e44ec
Compare
Contributor
Author
|
Updated+rebased and ready for review |
Codecov ReportAttention: Patch coverage is
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
pranavk-2003
pushed a commit
to pranavk-2003/navigation2
that referenced
this pull request
Jul 19, 2025
…navigation#5366) * [DEX] make CM pointcloud min_height and max_height Signed-off-by: nelson <kaichie.lee@gmail.com> * [DEX] fix CM dynamicParametersCallback override Signed-off-by: nelson <kaichie.lee@gmail.com> * adapt param validating style Signed-off-by: nelson <kaichie.lee@gmail.com> --------- Signed-off-by: nelson <kaichie.lee@gmail.com> Co-authored-by: Guillaume Doisy <guillaume@dexory.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
This PR adds the ability to dynamically reconfigure min_height and max_height in the Collision Monitor pointcloud source. (by @doisyg )
Description of documentation updates required from your changes
Description of how this change was tested
Future work that may be required in bullet points
For Maintainers:
backport-*.