Skip to content

Rename service_introspection_mode to introspection_mode#5321

Merged
SteveMacenski merged 1 commit intoros-navigation:mainfrom
mini-1235:fix/rename
Jul 2, 2025
Merged

Rename service_introspection_mode to introspection_mode#5321
SteveMacenski merged 1 commit intoros-navigation:mainfrom
mini-1235:fix/rename

Conversation

@mini-1235
Copy link
Copy Markdown
Collaborator

@mini-1235 mini-1235 commented Jul 2, 2025

Basic Info

Info Please fill out this column
Ticket(s) this addresses (add tickets here #1)
Primary OS tested on (Ubuntu, MacOS, Windows)
Robotic platform tested on (Steve's Robot, gazebo simulation of Tally, hardware turtlebot)
Does this PR contain AI generated software? (No; Yes and it is marked inline in the code)

Description of contribution in a few bullet points

Introspection mode now supports for both action and service, so rename it to introspection_mode to avoid ambiguity

Description of documentation updates required from your changes

Description of how this change was tested

Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists
  • Should this be backported to current distributions? If so, tag with backport-*.

@mini-1235
Rename service_introspection_mode to introspection_mode
5c2c0f4 
Signed-off-by: Maurice <mauricepurnawan@gmail.com>
@mini-1235 mini-1235 mentioned this pull request Jul 2, 2025
Merged
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 2, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
..._ros_common/include/nav2_ros_common/node_utils.hpp 90.47% <100.00%> (ø)
nav2_smac_planner/src/smac_planner_2d.cpp 93.30% <100.00%> (ø)
nav2_smac_planner/src/smac_planner_hybrid.cpp 87.13% <100.00%> (ø)

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SteveMacenski SteveMacenski merged commit f6c5cc6 into ros-navigation:main Jul 2, 2025
15 of 16 checks passed
SakshayMahna pushed a commit to SakshayMahna/navigation2 that referenced this pull request Jul 6, 2025
@mini-1235 @SakshayMahna
Rename service_introspection_mode to introspection_mode (ros-navigati…
d736c0d 
…on#5321)

Signed-off-by: Maurice <mauricepurnawan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SteveMacenski SteveMacenski SteveMacenski approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mini-1235 @SteveMacenski