Workaround for logger exception#532
Conversation
mkhansenbot
left a comment
There was a problem hiding this comment.
Something seems strange that this passed even though it uses the nav2_system_tests/params/nav2_params.yaml file and you didn't update that file to set use_sim_time=True. Am I missing something? How is this passing?
|
It passes because the It is basically the same as what we were doing before we started setting |
|
If that's the case, we can just remove the params file from the parameters list for those nodes that are only setting use_sim_time: amcl, navfn and simple_navigator and it should still pass |
|
Looks like you are correct. I just pushed that change. |
mkhansenbot
left a comment
There was a problem hiding this comment.
Looks good to me, thanks Carl!
| launch_ros.actions.Node( | ||
| package='nav2_amcl', | ||
| node_executable='amcl', | ||
| node_name='amcl', |
There was a problem hiding this comment.
I think this line is the only one that matters for working around ros2/rcl#375. The change to how parameters are passed doesn't look to be necessary.
There was a problem hiding this comment.
Ah never mind, I didn't realize launch required node_name when using this form of paramters
`[ERROR] [launch.LaunchService]: Caught exception in launch (see debug for traceback): If a dictionary of parameters is specified, the node name must also be specified. See https://github.com/ros2/launch/issues/139
|
@orduno or @SteveMacenski - can either of you approve so we can merge this and get the Travis master branch build back to green? |
|
Since #538 seems to be working, I'm closing this one. |
Basic Info
Description of contribution in a few bullet points
use_sim_timeparameter cannot be changed from the command line. Instead, if you want to use real time, you must manually change the nav2_params.yaml file. To fix this, we need to upgrade the ros2 launch tool, which is in the works.