Skip to content

Disable unstable system test in Travis.#527

Closed
ghost wants to merge 1 commit intomasterfrom
unknown repository
Closed

Disable unstable system test in Travis.#527
ghost wants to merge 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Jan 18, 2019

The system test is failing far more often than the 1% predicted. This is causing PRs and the master branch to show they are failing even though the fault is not part of that change.

This change disables the system test until it can be made more stable

@ruffsl ruffsl mentioned this pull request Jan 22, 2019
@ghost
Copy link
Copy Markdown
Author

ghost commented Jan 23, 2019

Looks like I was too quick to blame the test. Looks like we're getting this failure due to a change in the underlying ROS 2 library. Thanks @mkhansen-intel for finding this.

Certain nodes are throwing an exception:

terminate called after throwing an instance of 'rclcpp::exceptions::RCLError'
  what():  failed to initialize rcl node: Logger already initialized for node., at /home/rosbuild/ci_scripts/ws/src/ros2/rcl/rcl/src/rcl/logging_rosout.c:156

This is likely the root cause of the high failure rate. I'm closing this PR. We'll fix the underlying problem first.

@ghost ghost closed this Jan 23, 2019
@mkhansenbot
Copy link
Copy Markdown
Collaborator

I filed a bug here: ros2/rcl#375

@ghost ghost mentioned this pull request Jan 24, 2019
mini-1235 pushed a commit to mini-1235/navigation2 that referenced this pull request Feb 5, 2025
Forsyth-Creations pushed a commit to Forsyth-Creations/navigation2 that referenced this pull request Feb 19, 2025
* Use RT buffer for gripper action controller's goal handle

* fix format

---------

Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants