Add string error_msg to all action result messages (#4341)#4459
Merged
SteveMacenski merged 1 commit intoros-navigation:mainfrom Jun 24, 2024
Merged
Add string error_msg to all action result messages (#4341)#4459SteveMacenski merged 1 commit intoros-navigation:mainfrom
SteveMacenski merged 1 commit intoros-navigation:mainfrom
Conversation
Signed-off-by: Mike Wake <michael.wake@aosgrp.com.au>
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
SteveMacenski
approved these changes
Jun 24, 2024
ajtudela
pushed a commit
to ajtudela/navigation2
that referenced
this pull request
Jun 26, 2024
…) (ros-navigation#4459) Signed-off-by: Mike Wake <michael.wake@aosgrp.com.au>
ajtudela
pushed a commit
to ajtudela/navigation2
that referenced
this pull request
Jun 26, 2024
…) (ros-navigation#4459) Signed-off-by: Mike Wake <michael.wake@aosgrp.com.au>
Marc-Morcos
pushed a commit
to Marc-Morcos/navigation2
that referenced
this pull request
Jul 4, 2024
…) (ros-navigation#4459) Signed-off-by: Mike Wake <michael.wake@aosgrp.com.au>
Manos-G
pushed a commit
to Manos-G/navigation2
that referenced
this pull request
Aug 1, 2024
…) (ros-navigation#4459) Signed-off-by: Mike Wake <michael.wake@aosgrp.com.au>
stevedanomodolor
pushed a commit
to stevedanomodolor/navigation2
that referenced
this pull request
Apr 29, 2025
…) (ros-navigation#4459) Signed-off-by: Mike Wake <michael.wake@aosgrp.com.au> Signed-off-by: stevedanomodolor <stevedan.o.omodolor@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
Added
string error_msgto all action result messages anduint16 error_codewhere it was missing.Description of documentation updates required from your changes
Notify interface change.
Future work that may be required in bullet points
Future work is to make the changes to the action implementations to populate the error_msg / error_code fields where appropriate.
For Maintainers: