Use xacro file to plumb namespace into gz topics#4450
Merged
SteveMacenski merged 1 commit intoros-navigation:multirobotfrom Jun 19, 2024
Merged
Use xacro file to plumb namespace into gz topics#4450SteveMacenski merged 1 commit intoros-navigation:multirobotfrom
SteveMacenski merged 1 commit intoros-navigation:multirobotfrom
Conversation
This also removes the `use_simulator` launch argument since it's not needed by spawn_tb3.launch.py Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Contributor
|
@azeey, all pull requests must be targeted towards the |
SteveMacenski
approved these changes
Jun 19, 2024
SteveMacenski
added a commit
that referenced
this pull request
Jun 21, 2024
…#4457) * adding docking to multirobot launch files * Use xacro file to plumb namespace into gz topics (#4450) This also removes the `use_simulator` launch argument since it's not needed by spawn_tb3.launch.py Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> * fixing collision monitor * add launch files * update tests to use xacro * rever * Bump cache Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update underlay.repos Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org>
ajtudela
pushed a commit
to ajtudela/navigation2
that referenced
this pull request
Jun 26, 2024
…ros-navigation#4457) * adding docking to multirobot launch files * Use xacro file to plumb namespace into gz topics (ros-navigation#4450) This also removes the `use_simulator` launch argument since it's not needed by spawn_tb3.launch.py Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> * fixing collision monitor * add launch files * update tests to use xacro * rever * Bump cache Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update underlay.repos Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org>
ajtudela
pushed a commit
to ajtudela/navigation2
that referenced
this pull request
Jun 26, 2024
…ros-navigation#4457) * adding docking to multirobot launch files * Use xacro file to plumb namespace into gz topics (ros-navigation#4450) This also removes the `use_simulator` launch argument since it's not needed by spawn_tb3.launch.py Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> * fixing collision monitor * add launch files * update tests to use xacro * rever * Bump cache Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update underlay.repos Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org>
Marc-Morcos
pushed a commit
to Marc-Morcos/navigation2
that referenced
this pull request
Jul 4, 2024
…ros-navigation#4457) * adding docking to multirobot launch files * Use xacro file to plumb namespace into gz topics (ros-navigation#4450) This also removes the `use_simulator` launch argument since it's not needed by spawn_tb3.launch.py Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> * fixing collision monitor * add launch files * update tests to use xacro * rever * Bump cache Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update underlay.repos Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org>
Marc-Morcos
pushed a commit
to Marc-Morcos/navigation2
that referenced
this pull request
Jul 4, 2024
…ros-navigation#4457) * adding docking to multirobot launch files * Use xacro file to plumb namespace into gz topics (ros-navigation#4450) This also removes the `use_simulator` launch argument since it's not needed by spawn_tb3.launch.py Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> * fixing collision monitor * add launch files * update tests to use xacro * rever * Bump cache Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update underlay.repos Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org>
savalena
pushed a commit
to savalena/navigation2
that referenced
this pull request
Jul 5, 2024
…ros-navigation#4457) * adding docking to multirobot launch files * Use xacro file to plumb namespace into gz topics (ros-navigation#4450) This also removes the `use_simulator` launch argument since it's not needed by spawn_tb3.launch.py Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> * fixing collision monitor * add launch files * update tests to use xacro * rever * Bump cache Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update underlay.repos Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org>
Manos-G
pushed a commit
to Manos-G/navigation2
that referenced
this pull request
Aug 1, 2024
…ros-navigation#4457) * adding docking to multirobot launch files * Use xacro file to plumb namespace into gz topics (ros-navigation#4450) This also removes the `use_simulator` launch argument since it's not needed by spawn_tb3.launch.py Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> * fixing collision monitor * add launch files * update tests to use xacro * rever * Bump cache Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update underlay.repos Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org>
stevedanomodolor
pushed a commit
to stevedanomodolor/navigation2
that referenced
this pull request
Apr 29, 2025
…ros-navigation#4457) * adding docking to multirobot launch files * Use xacro file to plumb namespace into gz topics (ros-navigation#4450) This also removes the `use_simulator` launch argument since it's not needed by spawn_tb3.launch.py Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> * fixing collision monitor * add launch files * update tests to use xacro * rever * Bump cache Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update underlay.repos Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org> Signed-off-by: stevedanomodolor <stevedan.o.omodolor@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes both unique and cloned multirobot launch files by correctly name spacing gz topics via changes in ros-navigation/nav2_minimal_turtlebot_simulation#10
This also removes the
use_simulatorlaunch argument since it's not needed byspawn_tb3.launch.pyRequires: ros-navigation/nav2_minimal_turtlebot_simulation#10