changed slam launch file according to the comments for the PR #4211#4259
Closed
iOzcan1 wants to merge 1 commit intoros-navigation:mainfrom
Closed
changed slam launch file according to the comments for the PR #4211#4259iOzcan1 wants to merge 1 commit intoros-navigation:mainfrom
iOzcan1 wants to merge 1 commit intoros-navigation:mainfrom
Conversation
Contributor
|
@iOzcan1, your PR has failed to build. Please check CI outputs and resolve issues. |
SteveMacenski
approved these changes
Apr 11, 2024
Member
|
@iOzcan1 please fix the linting + DCO issues. You also need to rebase or pull in |
Contributor
|
@iOzcan1, your PR has failed to build. Please check CI outputs and resolve issues. |
…igation#4211 Signed-off-by: Ibrahim Özcan <ibrahim.ozcan@rwth-aachen.de>
Member
|
Linter is still failing :( You can see the details in Actions or https://app.circleci.com/pipelines/github/ros-planning/navigation2/11451/workflows/7b699eb7-8951-4c0d-986c-190fa7c26176/jobs/35289/tests |
Member
|
Will fix and open a PR shortly to get this in. @iOzcan1 thanks for getting this started! Very appreciated, but just going to finish up the details so that your contribution gets into main sooner than later 😄 |
SteveMacenski
added a commit
that referenced
this pull request
Apr 23, 2024
* changed slam launch file according to the comments for the PR #4211 Signed-off-by: Ibrahim Özcan <ibrahim.ozcan@rwth-aachen.de> * Fixing litning problems --------- Signed-off-by: Ibrahim Özcan <ibrahim.ozcan@rwth-aachen.de> Co-authored-by: Ibrahim Özcan <ibrahim.ozcan@rwth-aachen.de>
enricosutera
pushed a commit
to enricosutera/navigation2
that referenced
this pull request
May 19, 2024
* changed slam launch file according to the comments for the PR ros-navigation#4211 Signed-off-by: Ibrahim Özcan <ibrahim.ozcan@rwth-aachen.de> * Fixing litning problems --------- Signed-off-by: Ibrahim Özcan <ibrahim.ozcan@rwth-aachen.de> Co-authored-by: Ibrahim Özcan <ibrahim.ozcan@rwth-aachen.de> Signed-off-by: enricosutera <enricosutera@outlook.com>
Marc-Morcos
pushed a commit
to Marc-Morcos/navigation2
that referenced
this pull request
Jul 4, 2024
* changed slam launch file according to the comments for the PR ros-navigation#4211 Signed-off-by: Ibrahim Özcan <ibrahim.ozcan@rwth-aachen.de> * Fixing litning problems --------- Signed-off-by: Ibrahim Özcan <ibrahim.ozcan@rwth-aachen.de> Co-authored-by: Ibrahim Özcan <ibrahim.ozcan@rwth-aachen.de>
savalena
pushed a commit
to savalena/navigation2
that referenced
this pull request
Jul 5, 2024
* changed slam launch file according to the comments for the PR ros-navigation#4211 Signed-off-by: Ibrahim Özcan <ibrahim.ozcan@rwth-aachen.de> * Fixing litning problems --------- Signed-off-by: Ibrahim Özcan <ibrahim.ozcan@rwth-aachen.de> Co-authored-by: Ibrahim Özcan <ibrahim.ozcan@rwth-aachen.de>
Manos-G
pushed a commit
to Manos-G/navigation2
that referenced
this pull request
Aug 1, 2024
* changed slam launch file according to the comments for the PR ros-navigation#4211 Signed-off-by: Ibrahim Özcan <ibrahim.ozcan@rwth-aachen.de> * Fixing litning problems --------- Signed-off-by: Ibrahim Özcan <ibrahim.ozcan@rwth-aachen.de> Co-authored-by: Ibrahim Özcan <ibrahim.ozcan@rwth-aachen.de>
stevedanomodolor
pushed a commit
to stevedanomodolor/navigation2
that referenced
this pull request
Apr 29, 2025
* changed slam launch file according to the comments for the PR ros-navigation#4211 Signed-off-by: Ibrahim Özcan <ibrahim.ozcan@rwth-aachen.de> * Fixing litning problems --------- Signed-off-by: Ibrahim Özcan <ibrahim.ozcan@rwth-aachen.de> Co-authored-by: Ibrahim Özcan <ibrahim.ozcan@rwth-aachen.de> Signed-off-by: stevedanomodolor <stevedan.o.omodolor@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
Description of documentation updates required from your changes
Future work that may be required in bullet points
For Maintainers: