Fix compiler warning ‘error_level’ may be used uninitialized#4253
Merged
SteveMacenski merged 1 commit intoros-navigation:mainfrom Apr 10, 2024
Merged
Fix compiler warning ‘error_level’ may be used uninitialized#4253SteveMacenski merged 1 commit intoros-navigation:mainfrom
SteveMacenski merged 1 commit intoros-navigation:mainfrom
Conversation
Contributor
Author
|
Alternatively auto error_level = diagnostic_msgs::msg::DiagnosticStatus::ERROR;But I thought that might perhaps lead to confusion. |
Signed-off-by: Tim Clephas <tim.clephas@nobleo.nl>
SteveMacenski
approved these changes
Apr 10, 2024
ajtudela
pushed a commit
to grupo-avispa/navigation2
that referenced
this pull request
Apr 19, 2024
…igation#4253) Signed-off-by: Tim Clephas <tim.clephas@nobleo.nl>
enricosutera
pushed a commit
to enricosutera/navigation2
that referenced
this pull request
May 19, 2024
…igation#4253) Signed-off-by: Tim Clephas <tim.clephas@nobleo.nl> Signed-off-by: enricosutera <enricosutera@outlook.com>
Marc-Morcos
pushed a commit
to Marc-Morcos/navigation2
that referenced
this pull request
Jul 4, 2024
…igation#4253) Signed-off-by: Tim Clephas <tim.clephas@nobleo.nl>
Manos-G
pushed a commit
to Manos-G/navigation2
that referenced
this pull request
Aug 1, 2024
…igation#4253) Signed-off-by: Tim Clephas <tim.clephas@nobleo.nl>
stevedanomodolor
pushed a commit
to stevedanomodolor/navigation2
that referenced
this pull request
Apr 29, 2025
…igation#4253) Signed-off-by: Tim Clephas <tim.clephas@nobleo.nl> Signed-off-by: stevedanomodolor <stevedan.o.omodolor@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
Since
-Werroris enforced in navigation2, it was unable to compile on newer cmake versions (ROS rolling, ubuntu Nobleo, cmake 3.28.3).For Maintainers: