New Graceful Motion Controller by ajtudela · Pull Request #4021 · ros-navigation/navigation2

ajtudela · 2023-12-20T20:41:26Z

Basic Info

Info	Please fill out this column
Ticket(s) this addresses	#1975
Primary OS tested on	Ubuntu 22.04
Robotic platform tested on	Ignition Gazebo
Does this PR contain AI generated software?	No

Description of contribution in a few bullet points

Added a new version of the graceful controller based on the smooth control law with similar settings to the existing controllers.
I think I need to add more tests to increase the test coverage.

Description of documentation updates required from your changes

New entry in configuration page: https://navigation.ros.org/configuration/index.html
New entry in plugins: https://navigation.ros.org/plugins/index.html#controllers

Future work that may be required in bullet points

For Maintainers:

Check that any new parameters added are updated in navigation.ros.org
Check that any significant change is added to the migration guide
Check that any new features OR changes to existing behaviors are reflected in the tuning guide
Check that any new functions have Doxygen added
Check that any new features have test coverage
Check that any new plugins is added to the plugins page
If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

codecov · 2023-12-20T20:52:34Z

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (7872bfa) 90.34% compared to head (dc4f154) 90.48%.
Report is 17 commits behind head on main.

❗ Current head dc4f154 differs from pull request most recent head e90e26e. Consider uploading reports for the commit e90e26e to get more accurate results

Files	Patch %	Lines
...tion_controller/src/graceful_motion_controller.cpp	91.80%	10 Missing ⚠️
...v2_graceful_motion_controller/src/path_handler.cpp	94.28%	2 Missing ⚠️
...aceful_motion_controller/src/parameter_handler.cpp	98.85%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4021      +/-   ##
==========================================
+ Coverage   90.34%   90.48%   +0.14%     
==========================================
  Files         415      424       +9     
  Lines       18583    18892     +309     
==========================================
+ Hits        16788    17095     +307     
- Misses       1795     1797       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

nav2_graceful_motion_controller/test/CMakeLists.txt

nav2_graceful_motion_controller/graceful_controller_plugin.xml

nav2_graceful_motion_controller/package.xml

SteveMacenski · 2023-12-20T21:18:50Z

Yes, more test coverage is definitely needed: https://app.codecov.io/gh/ros-planning/navigation2/pull/4021/tree/nav2_graceful_motion_controller/src. We accept new packages at 90%+ test coverage, though you should aim for as much as is reasonably possible (e.g. missing a stray line due to an edge case within an impossible edge case is -- like not being able to lock the node's shared pointer 🤷)

You also have a few linting issues that CI will probably bring up, but you can find with ament_cpplint and ament_uncrustify

I'm pleasantly surprised by the quality of this PR so this shouldn't be a huge effort for me to review even though its a big update. I did a once over on obvious things in the meantime since I don't have the cycles to give it a deep review right now, but I did want to give you feedback on tests / things you can do immediately in the meantime.

It would also be good for @mikeferguson to review this one as well given his experience. He might be able to find errors faster than I and have feedback on good bells and whistles to add that are missing.

ajtudela · 2023-12-22T20:47:20Z

Thanks for the compliment, Steve. Sorry, to make this PR later than I though but I've been very busy this past months and I preferred to upload the code as complete as possible.

In the meantime, I'll fix the linting issues and I'll working in the new tests to increase the coverage

SteveMacenski · 2023-12-22T20:51:52Z

A nice demo video highlighting this controller's value would be great too both for here & for the documentation

SteveMacenski · 2024-01-03T02:42:57Z

Hi! I'm really excited for this work and its very timely - a docking effort will begin shortly which can definitely leverage this core work. any updates on your side? I know we're just now back from the holidays so no worries!

nav2_graceful_motion_controller/include/nav2_graceful_motion_controller/ego_polar_coords.hpp

nav2_graceful_motion_controller/include/nav2_graceful_motion_controller/smooth_control_law.hpp

nav2_graceful_motion_controller/src/smooth_control_law.cpp

nav2_graceful_motion_controller/src/path_handler.cpp

nav2_graceful_motion_controller/src/graceful_motion_controller.cpp

ajtudela · 2024-01-03T11:38:18Z

Hi Steve, sorry for not making the video, I'm still on Christmas holidays until Monday. I did new tests on the last day before the holidays, but I left a few until we reach 90%+ coverage. So, it's almost done.

I'll review your changes; they don't seem very difficult to do.

I'm thrilled to work on the docking implementation. #1975

mergify · 2024-01-12T17:55:27Z

@ajtudela, your PR has failed to build. Please check CI outputs and resolve issues.
You may need to rebase or pull in main due to API changes (or your contribution genuinely fails).

Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

ajtudela · 2024-01-12T18:06:04Z

I think I fixed all the requested changes.

mergify · 2024-01-12T18:14:23Z

@ajtudela, your PR has failed to build. Please check CI outputs and resolve issues.
You may need to rebase or pull in main due to API changes (or your contribution genuinely fails).

Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

SteveMacenski · 2024-01-31T23:40:10Z

Let us know when you're ready for another review!

ajtudela · 2024-01-31T23:43:07Z

I'm ready. I made all the requested changes.

SteveMacenski · 2024-01-31T23:55:48Z

@mikeferguson please re-review

nav2_graceful_motion_controller/src/graceful_motion_controller.cpp

SteveMacenski · 2024-02-01T00:08:45Z

But overall the code looks really good! I'm leaning on Fergs for a details algorithm review and subtle details from his expertise. He still has several of his original comments unaddressed

Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

ajtudela · 2024-02-01T17:33:13Z

I'm ready. I made all the requested changes.

But overall the code looks really good! I'm leaning on Fergs for a details algorithm review and subtle details from his expertise. He still has several of his original comments unaddressed

I agreed. I think I made most of the changes proposed by Fergs but I let the rest of that part to him.

SteveMacenski · 2024-02-01T21:13:05Z

nav2_graceful_motion_controller/src/graceful_motion_controller.cpp

+  }
+
+  // Limit the angular velocity to be proportional to the linear velocity
+  params_->v_angular_max = params_->v_linear_max * params_->rotation_scaling_factor;


Why would either of these values appear in this expression? It should be something like the proportion of max linear velocity reduction times the original max angular velocity to scale it down proportionately to the requested linear velocity reduction. Try checking out other implementations

SteveMacenski · 2024-02-01T21:48:32Z

OK on the Fergs items. We discussed in the Working Group meeting today that we can merge in once you finish up these last couple details with the dynamic parameters and speed limits. The remaining items @mikeferguson will enumerate here, then we can merge this (thanks so much!) and he can pick those up in a follow on PR!

Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

SteveMacenski · 2024-02-02T19:50:44Z

Looks good to me! Fergs?

The last bits are just documentation! Adding the new plugin to the Configuration Guide with the parameters and a few sentences up top about what it is & announcing it on the Migration Guide and in the Navigation Plugins table.

mikeferguson

We can almost merge this - remaining issues:

The v_linear_min issue I just raised (I found this during some other testing)
Add the name of the updated paper to the README
Address the collision checking concerns that Steve raised

Things that I will do in a follow on PR:

Revamp the controller body to "search" for a motion target (I can re-license and merge the stuff from my controller because I personally hold the copyright on that)
Likely adjust some parameter defaults based on experience with running this kind of controller on a number of robots

nav2_graceful_motion_controller/include/nav2_graceful_motion_controller/parameter_handler.hpp

nav2_graceful_motion_controller/src/smooth_control_law.cpp

Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

ajtudela · 2024-02-05T17:58:31Z

Thanks @mikeferguson!!
I fixed the minor issues with the velocity and Readme and I think the collision cheking is also fixed.

I made a PR for the docs here: 517

SteveMacenski · 2024-02-05T20:21:25Z

One small typo on the documentation, but otherwise LGTM!

@mikeferguson are these comments still pending and/or items you plan to address? Just want to make sure we don't leave anything hanging. I went through the code in detail on the ROS2-y things, but left the main control law to your review. It sounds like the finding of the carrot is going to change alot, I had some gripes with that, but no need to so anything if that's getting redone anyway.

I believe this will be wrong when the robot is "reversing" (which is a case not handled by the paper, but which occurs in the real world)

I think there is a subtle bug here if current.orientation isn't always 0 (I think we get that right now because you transform the plan into the local frame before proceeding, right?

I would recommend you actually use the angle_to_target rather than a fixed -1/+1 - and then have a scaling parameter - otherwise this almost sure to overshoot (you'll be going max_angular_v as you cross the goal, and you still need to decelerate)

@ajtudela Overall, really great work on all of this. Definitely great code quality, functionality, and understanding of the important trade offs, I'm very impressed! I'd welcome your help anytime on any subjects your find interest in! 😄

ajtudela · 2024-02-05T20:51:11Z

@ajtudela Overall, really great work on all of this. Definitely great code quality, functionality, and understanding of the important trade offs, I'm very impressed! I'd welcome your help anytime on any subjects your find interest in! 😄

Thank you very much! It was hard at first, especially because of the tests, I'm not used to doing them. But after so many commits I've gotten the hang of it and I'm starting to love them. :D

Of course. Next project: docking in nav2!

mikeferguson · 2024-02-05T20:53:50Z

I believe this will be wrong when the robot is "reversing" (which is a case not handled by the paper, but which occurs in the real world)

As close as I can tell without manually testing, yes this is now resolved. I can fix any remaining issues when doing the carrot overhaul.

I think there is a subtle bug here if current.orientation isn't always 0 (I think we get that right now because you transform the plan into the local frame before proceeding, right?

It's not an issue for the codebase as-is - and it does make the EpiPolar code more generic as currently implemented. I only see it as a potential trap for someone who comes in and modifies this code without realizing the assumption. I figured I would leave the comment unresolved there in case anyone someday comes back through this because they didn't realize those assumptions.

I would recommend you actually use the angle_to_target rather than a fixed -1/+1 - and then have a scaling parameter - otherwise this almost sure to overshoot (you'll be going max_angular_v as you cross the goal, and you still need to decelerate)

Yes, this is resolved

SteveMacenski · 2024-02-05T21:31:41Z

Great! Any objections to a merge @mikeferguson ?

@ajtudela this is a great contribution as to part of Docking. Currently, Fergs and I are working on such a thing and the vast majority of it is done, in part thanks to your work! That should be released in the coming month or two depending on the testing hiccups. Unfortunately, it is part of a project funded by a company, so I can't share the WIP code with you for your help (that was sponsored after we chatted about this; sorry!) so there's not much I can actually get your help on besides this for the docking framework. My apologies, but this was a great step that has made it into the final docking framework and a meaningful contribution there! To be honest, the rest of the Docking work is alot of software engineering and less algorithmic, you did the fun algorithmic parts :-)

I'd be more than happy to have your help on other projects however!

mikeferguson · 2024-02-06T03:33:49Z

No objections

SteveMacenski · 2024-02-06T04:31:58Z

@ajtudela last-last thing, you have a test failure:

/opt/overlay_ws/src/navigation2/nav2_graceful_motion_controller/test/test_graceful_motion_controller.cpp:1119
Expected: (cmd_vel.twist.linear.x) < (0.0), actual: 0.1 vs 0/opt/overlay_ws/src/navigation2/nav2_graceful_motion_controller/test/test_graceful_motion_controller.cpp:1120
Expected: (cmd_vel.twist.angular.z) < (0.0), actual: 0.293018 vs 0

Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

ajtudela · 2024-02-06T17:05:23Z

ups, fixed!

* Initial commit Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Fix egopolar and add compute next pose Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Added simulated trajectory Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Added slowdown publisher Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Added first tests Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Added basic tests and smoth control Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Added initial rotation Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Added final rotation Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Added collision Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Improve last motion target Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Added new tests Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Set min velocity Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Added EOL Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Path test Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Add utils and minor fixes Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Update footprint calculation Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Added more tests Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Added nav2_controller to package test Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Improve comments Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Added backward motion Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Split in two libraries Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Improve rotation velocity Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Update documentation Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Minor fixes Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Revert collision_checker Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Pass costmap transform to simulate trajectory Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Retain old headers Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Update dyn parameters of control law Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Better comment in test Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Update setSpeedLimits with angular vel max Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Fix SpeedLimits Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Fixes in vel and collision Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Fix backward motion Signed-off-by: Alberto Tudela <ajtudela@gmail.com> --------- Signed-off-by: Alberto Tudela <ajtudela@gmail.com> Signed-off-by: enricosutera <enricosutera@outlook.com>

* Initial commit Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Fix egopolar and add compute next pose Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Added simulated trajectory Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Added slowdown publisher Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Added first tests Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Added basic tests and smoth control Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Added initial rotation Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Added final rotation Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Added collision Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Improve last motion target Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Added new tests Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Set min velocity Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Added EOL Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Path test Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Add utils and minor fixes Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Update footprint calculation Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Added more tests Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Added nav2_controller to package test Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Improve comments Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Added backward motion Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Split in two libraries Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Improve rotation velocity Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Update documentation Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Minor fixes Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Revert collision_checker Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Pass costmap transform to simulate trajectory Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Retain old headers Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Update dyn parameters of control law Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Better comment in test Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Update setSpeedLimits with angular vel max Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Fix SpeedLimits Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Fixes in vel and collision Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Fix backward motion Signed-off-by: Alberto Tudela <ajtudela@gmail.com> --------- Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

* Initial commit Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Fix egopolar and add compute next pose Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Added simulated trajectory Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Added slowdown publisher Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Added first tests Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Added basic tests and smoth control Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Added initial rotation Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Added final rotation Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Added collision Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Improve last motion target Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Added new tests Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Set min velocity Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Added EOL Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Path test Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Add utils and minor fixes Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Update footprint calculation Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Added more tests Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Added nav2_controller to package test Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Improve comments Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Added backward motion Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Split in two libraries Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Improve rotation velocity Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Update documentation Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Minor fixes Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Revert collision_checker Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Pass costmap transform to simulate trajectory Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Retain old headers Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Update dyn parameters of control law Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Better comment in test Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Update setSpeedLimits with angular vel max Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Fix SpeedLimits Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Fixes in vel and collision Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Fix backward motion Signed-off-by: Alberto Tudela <ajtudela@gmail.com> --------- Signed-off-by: Alberto Tudela <ajtudela@gmail.com> Signed-off-by: stevedanomodolor <stevedan.o.omodolor@gmail.com>

SteveMacenski requested changes Dec 20, 2023

View reviewed changes

SteveMacenski requested changes Jan 3, 2024

View reviewed changes

ajtudela added 17 commits January 12, 2024 19:03

Initial commit

d172d94

Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

Fix egopolar and add compute next pose

6b41f54

Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

Added simulated trajectory

6fbcb99

Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

Added slowdown publisher

442b9a8

Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

Added first tests

d7269b1

Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

Added basic tests and smoth control

c048f57

Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

Added initial rotation

be22740

Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

Added final rotation

f17c391

Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

Added collision

7e23fb6

Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

Improve last motion target

3bd19be

Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

Added new tests

eebef21

Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

Set min velocity

f3caed4

Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

Added EOL

1c06dee

Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

Path test

2f23f74

Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

Add utils and minor fixes

7b5c3a6

Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

Update footprint calculation

bceec62

Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

Added more tests

f745c7a

Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

ajtudela force-pushed the feature/graceful_controller branch from 47a461c to f745c7a Compare January 12, 2024 18:03

Added nav2_controller to package test

dc4f154

Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

ajtudela force-pushed the feature/graceful_controller branch from 9afb4c4 to 2e230b0 Compare January 31, 2024 07:23

Better comment in test

c5169ad

Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

SteveMacenski requested changes Feb 1, 2024

View reviewed changes

nav2_graceful_motion_controller/src/graceful_motion_controller.cpp Outdated Show resolved Hide resolved

nav2_graceful_motion_controller/src/graceful_motion_controller.cpp Outdated Show resolved Hide resolved

Update setSpeedLimits with angular vel max

129eb07

Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

SteveMacenski reviewed Feb 1, 2024

View reviewed changes

Fix SpeedLimits

45b5316

Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

mikeferguson suggested changes Feb 5, 2024

View reviewed changes

nav2_graceful_motion_controller/include/nav2_graceful_motion_controller/parameter_handler.hpp Show resolved Hide resolved

nav2_graceful_motion_controller/src/smooth_control_law.cpp Outdated Show resolved Hide resolved

Fixes in vel and collision

05e0edc

Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

ajtudela mentioned this pull request Feb 5, 2024

Documentation for Graceful Motion ros-navigation/docs.nav2.org#517

Merged

Fix backward motion

a217e4e

Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

SteveMacenski merged commit b8f51ae into ros-navigation:main Feb 6, 2024

Conversation

ajtudela commented Dec 20, 2023

Basic Info

Description of contribution in a few bullet points

Description of documentation updates required from your changes

Future work that may be required in bullet points

For Maintainers:

Uh oh!

codecov bot commented Dec 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SteveMacenski commented Dec 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ajtudela commented Dec 22, 2023

Uh oh!

SteveMacenski commented Dec 22, 2023

Uh oh!

SteveMacenski commented Jan 3, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ajtudela commented Jan 3, 2024

Uh oh!

mergify bot commented Jan 12, 2024

Uh oh!

ajtudela commented Jan 12, 2024

Uh oh!

mergify bot commented Jan 12, 2024

Uh oh!

SteveMacenski commented Jan 31, 2024

Uh oh!

ajtudela commented Jan 31, 2024

Uh oh!

SteveMacenski commented Jan 31, 2024

Uh oh!

Uh oh!

Uh oh!

SteveMacenski commented Feb 1, 2024

Uh oh!

ajtudela commented Feb 1, 2024

Uh oh!

SteveMacenski Feb 1, 2024

Choose a reason for hiding this comment

Uh oh!

SteveMacenski commented Feb 1, 2024

Uh oh!

SteveMacenski commented Feb 2, 2024

Uh oh!

mikeferguson left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ajtudela commented Feb 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SteveMacenski commented Feb 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ajtudela commented Feb 5, 2024

Uh oh!

mikeferguson commented Feb 5, 2024

Uh oh!

SteveMacenski commented Feb 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mikeferguson commented Feb 6, 2024

codecov bot commented Dec 20, 2023 •

edited

Loading

SteveMacenski commented Dec 20, 2023 •

edited

Loading

ajtudela commented Feb 5, 2024 •

edited

Loading

SteveMacenski commented Feb 5, 2024 •

edited

Loading

SteveMacenski commented Feb 5, 2024 •

edited

Loading