Improve KeepoutFilter mask receiving performance#3420
Merged
SteveMacenski merged 1 commit intoros-navigation:mainfrom Feb 22, 2023
Merged
Conversation
Contributor
|
This pull request is in conflict. Could you fix it @AlexeyMerzlyakov? |
acd3106 to
dbdaa95
Compare
SteveMacenski
approved these changes
Feb 22, 2023
7 tasks
andrewlycas
pushed a commit
to StratomInc/navigation2
that referenced
this pull request
Feb 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not copy
OccupancyGridmask -> toCostmap2Din mask receiving callback. Directly store and useOccupancyGridmask instead.Basic Info
Description of contribution in a few bullet points
CostmapFilter::getMaskCost(OccupancyGrid::SharedPtr filter_mask, & mx, & my)routine to CostmapFilter, which will convert OccupancyGrid values to Costmap2D ones; and will be called each time, when we need to update master costmap cell in the rolling window duringKeepoutFilter::process()Description of documentation updates required from your changes
Additional notes
For Maintainers: