Skip to content

fix: Removed additional sign multiplication in RPP angular velocity (in backward motion)#3088

Merged
SteveMacenski merged 1 commit intoros-navigation:mainfrom
automech-rb:rpp-reverse-debug
Aug 19, 2022
Merged

fix: Removed additional sign multiplication in RPP angular velocity (in backward motion)#3088
SteveMacenski merged 1 commit intoros-navigation:mainfrom
automech-rb:rpp-reverse-debug

Conversation

@automech-rb
Copy link
Copy Markdown
Contributor


Basic Info

Info Please fill out this column
Ticket(s) this addresses #3086
Primary OS tested on Docker 20.04 Ubuntu
Robotic platform tested on Ignition differential sim

Description of contribution in a few bullet points

Removed the additional sign* bug from this PR.

Description of documentation updates required from your changes

None


Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in navigation.ros.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 23, 2022

@automech-rb, please properly fill in PR template in the future. @SteveMacenski, use this instead.

  • Check that any new parameters added are updated in navigation.ros.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

@automech-rb automech-rb changed the title fix: Removed additional sign multiplication in RPP angular velocity (backward motion) fix: Removed additional sign multiplication in RPP angular velocity (in backward motion) Jul 23, 2022
@SteveMacenski SteveMacenski merged commit ef76b5b into ros-navigation:main Aug 19, 2022
mergify bot pushed a commit that referenced this pull request Aug 19, 2022
mergify bot pushed a commit that referenced this pull request Aug 19, 2022
SteveMacenski pushed a commit that referenced this pull request Aug 19, 2022
(cherry picked from commit ef76b5b)

Co-authored-by: autome <rohit.bhor111.rb@gmail.com>
SteveMacenski pushed a commit that referenced this pull request Aug 19, 2022
(cherry picked from commit ef76b5b)

Co-authored-by: autome <rohit.bhor111.rb@gmail.com>
jwallace42 pushed a commit to jwallace42/navigation2 that referenced this pull request Aug 22, 2022
hodgespodge pushed a commit to RobotCodeLab/navigation2 that referenced this pull request Sep 12, 2022
…igation#3126)

(cherry picked from commit ef76b5b)

Co-authored-by: autome <rohit.bhor111.rb@gmail.com>
jwallace42 pushed a commit to jwallace42/navigation2 that referenced this pull request Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants