Merged
Conversation
Contributor
|
@mradams-bastian, please properly fill in PR template in the future. @SteveMacenski, use this instead.
|
Member
|
To give a heads up, there are some linter issues, that you might want to fix.. see the details in the release test. You can also get those results locally by simply running |
SteveMacenski
requested changes
Jun 3, 2022
Member
SteveMacenski
left a comment
There was a problem hiding this comment.
LGTM, I don't usually mention by hand the linting errors, but I want to get this done ASAP so I can release this afternoon
nav2_bt_navigator/include/nav2_bt_navigator/navigators/navigate_to_pose.hpp
Outdated
Show resolved
Hide resolved
nav2_bt_navigator/include/nav2_bt_navigator/navigators/navigate_through_poses.hpp
Outdated
Show resolved
Hide resolved
Contributor
Author
|
K, I'll get those fixed soon |
Member
|
Toggling for CI, it didn't trigger for some reason |
Member
|
Thanks @mradams-bastian! |
redvinaa
pushed a commit
to EnjoyRobotics/navigation2
that referenced
this pull request
Jun 30, 2022
* Added goal accepted check before flagging navigator as running * Added final bt status as a parameter to goal completed callback of navigators (for reference) * Formatting for line length * Fixed indentation formatting * Fixed indentation formatting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
Added input parameter 'final_bt_status' of type nav2_behavior_tree::BtStatus to the goalCompleted() function of navigator.hpp that makes the final status of the behavior tree run available to the navigator. This could provide the navigator with important context while populating the result and doing anything else it might do during that function.
None of the navigators that are included in nav2 currently do anything with this goalCompleted() function, but this could be a nice feature for developers who are creating their own custom navigators, and the current nav2 navigators may also benefit from this feature in the future. For example, a parameter in the result message could provide some context to the client as to whether an aborted result corresponds to a preemption or a behavior tree failure.
For Maintainers: