Skip to content

Backport_galactic: correct curvature signal on RPP (#2979)#2995

Merged
SteveMacenski merged 1 commit intoros-navigation:galacticfrom
brisa-robotics:backport_galactic
Jun 2, 2022
Merged

Backport_galactic: correct curvature signal on RPP (#2979)#2995
SteveMacenski merged 1 commit intoros-navigation:galacticfrom
brisa-robotics:backport_galactic

Conversation

@afonsofonbraga
Copy link
Contributor

@afonsofonbraga afonsofonbraga commented Jun 2, 2022

  • fix: correct curvature signal

Signed-off-by: Afonso da Fonseca Braga afonso.braga@engenharia.ufjf.br

  • cleanup: move sign's position

Signed-off-by: Afonso da Fonseca Braga afonso.braga@engenharia.ufjf.br

Basic Info

Info Please fill out this column
Ticket(s) this addresses Backport PR #2979
Primary OS tested on Ubuntu
Robotic platform tested on Gazebo Tricycle

Description of contribution in a few bullet points

Hi! Thanks for approving the other PR! I would like to backport it to the galactic branch too. 😄
Backporting from #2979

Description of documentation updates required from your changes

Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in navigation.ros.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

@afonsofonbraga
fix: correct curvature signal on RPP (ros-navigation#2979)
d4d1883 
* fix: correct curvature signal

Signed-off-by: Afonso da Fonseca Braga <afonso.braga@engenharia.ufjf.br>

* cleanup: move sign's position

Signed-off-by: Afonso da Fonseca Braga <afonso.braga@engenharia.ufjf.br>
@mergify
Copy link
Contributor

mergify bot commented Jun 2, 2022

@afonsofonbraga, all pull requests must be targeted towards the main development branch.
Once merged into main, it is possible to backport to @galactic, but it must be in main
to have these changes reflected into new distributions.

@mergify
Copy link
Contributor

mergify bot commented Jun 2, 2022

@afonsofonbraga, please properly fill in PR template in the future. @SteveMacenski, use this instead.

  • Check that any new parameters added are updated in navigation.ros.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

@SteveMacenski SteveMacenski merged commit 87af505 into ros-navigation:galactic Jun 2, 2022
hodgespodge pushed a commit to RobotCodeLab/navigation2 that referenced this pull request Sep 12, 2022
@afonsofonbraga @hodgespodge
fix: correct curvature signal on RPP (ros-navigation#2979) (ros-navig…
b39c7d5 
…ation#2995)

* fix: correct curvature signal

Signed-off-by: Afonso da Fonseca Braga <afonso.braga@engenharia.ufjf.br>

* cleanup: move sign's position

Signed-off-by: Afonso da Fonseca Braga <afonso.braga@engenharia.ufjf.br>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SteveMacenski SteveMacenski SteveMacenski approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@afonsofonbraga @SteveMacenski