Change all shared_ptr references to shared_ptr#2976
Merged
SteveMacenski merged 2 commits intoros-navigation:mainfrom May 31, 2022
Merged
Change all shared_ptr references to shared_ptr#2976SteveMacenski merged 2 commits intoros-navigation:mainfrom
SteveMacenski merged 2 commits intoros-navigation:mainfrom
Conversation
Contributor
|
@naiveHobo, please properly fill in PR template in the future. @SteveMacenski, use this instead.
|
SteveMacenski
approved these changes
May 27, 2022
Member
SteveMacenski
left a comment
There was a problem hiding this comment.
Just needs https://navigation.ros.org/migration/Galactic.html Migration guide for API change (towards the top)
Member
|
Member
|
I made the change, just waiting on another run of CI |
redvinaa
pushed a commit
to EnjoyRobotics/navigation2
that referenced
this pull request
Jun 30, 2022
* Change all shared_ptr references to shared_ptr * Update simple_smoother.cpp Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
doisyg
pushed a commit
to wyca-robotics/teb_local_planner
that referenced
this pull request
Jul 5, 2022
SteveMacenski
pushed a commit
to rst-tu-dortmund/teb_local_planner
that referenced
this pull request
Sep 12, 2022
* new lib g2o * FootprintModel in Tebconfig and make it dynamic (no type change allowed) * change dyn param method * dynamically get robot_base_frame from costmap * use only one global_frame variable (from cfg) * remove map_frame param since it is set from costmap * tf2_geometry_msgs.h depreciation * nav2 PR 2976 ros-navigation/navigation2#2976 * fix compiler warnings * fix costmap_converter plugin load * Merge from ros2-master * unneeded register_type function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
const shared_ptr &references toshared_ptrs so counter increment takes place properlyDescription of documentation updates required from your changes
Future work that may be required in bullet points
For Maintainers: