Skip to content

removing the filter message warnings#1574

Merged
SteveMacenski merged 1 commit intoros-navigation:masterfrom
SteveMacenski:949
Mar 2, 2020
Merged

removing the filter message warnings#1574
SteveMacenski merged 1 commit intoros-navigation:masterfrom
SteveMacenski:949

Conversation

@SteveMacenski
Copy link
Member

@SteveMacenski SteveMacenski commented Mar 2, 2020

Basic Info

Info Please fill out this column
Ticket(s) this addresses #949
Primary OS tested on Ubuntu
Robotic platform tested on gazebo simulation of TB3

Description of contribution in a few bullet points

  • Removed all nav stack message filter dropped messages

Description of documentation updates required from your changes

  • N/A

Future work that may be required in bullet points

  • RViz still produces them

This was referenced Mar 2, 2020
Closed
Closed
@SteveMacenski SteveMacenski merged commit 2ec4507 into ros-navigation:master Mar 2, 2020
@codecov
Copy link

codecov bot commented Mar 2, 2020

Codecov Report

Merging #1574 into master will increase coverage by 0.06%.
The diff coverage is 40%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1574      +/-   ##
==========================================
+ Coverage   37.76%   37.82%   +0.06%     
==========================================
  Files         227      227              
  Lines       11889    11893       +4     
  Branches     5202     5206       +4     
==========================================
+ Hits         4490     4499       +9     
+ Misses       3936     3921      -15     
- Partials     3463     3473      +10
Flag Coverage Δ
#project 37.82% <40%> (+0.06%) ⬆️
Impacted Files Coverage Δ
nav2_costmap_2d/src/costmap_2d_ros.cpp 27.23% <100%> (+1.16%) ⬆️
nav2_costmap_2d/plugins/obstacle_layer.cpp 41.66% <25%> (+2.23%) ⬆️
nav2_map_server/src/map_server.cpp 40.47% <0%> (-4.77%) ⬇️
...ontroller/dwb_plugins/src/kinematic_parameters.cpp 14.43% <0%> (-4.13%) ⬇️
nav2_amcl/src/amcl_node.cpp 38.84% <0%> (-0.32%) ⬇️
nav2_costmap_2d/src/collision_checker.cpp 50% <0%> (ø) ⬆️
nav2_controller/src/nav2_controller.cpp 26.17% <0%> (ø) ⬆️
nav2_navfn_planner/src/navfn.cpp 61.63% <0%> (+0.43%) ⬆️
nav2_costmap_2d/plugins/static_layer.cpp 32.51% <0%> (+0.61%) ⬆️
nav2_costmap_2d/src/observation_buffer.cpp 41.17% <0%> (+0.98%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfc202e...f8b94c9. Read the comment docs.

This was referenced May 6, 2021
Closed
Closed
@TanmayDeshmukh TanmayDeshmukh mentioned this pull request Apr 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@SteveMacenski