Skip to content

[multirobot - Part4] Multiple robot control via RVIZ#1149

Merged
orduno merged 1 commit intomulti-robot/multi-robot_launch_filesfrom
multi-robot/rviz
Sep 30, 2019
Merged

[multirobot - Part4] Multiple robot control via RVIZ#1149
orduno merged 1 commit intomulti-robot/multi-robot_launch_filesfrom
multi-robot/rviz

Conversation

@orduno
Copy link
Copy Markdown
Contributor

@orduno orduno commented Sep 20, 2019


Basic Info

Info Please fill out this column
Ticket(s) this addresses #
Primary OS tested on Ubuntu 18.04
Robotic platform tested on Gazebo simulation of TB3

Description of contribution in a few bullet points

Last stacked PR

Extends #1148. Adds functionality to launch one RVIZ instance per robot.
Each instance is set with the correct namespacing for controlling the corresponding robot.


Future work that may be required in bullet points

@orduno orduno self-assigned this Sep 20, 2019
Copy link
Copy Markdown

@bpwilcox bpwilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outside the scope of this PR, but it would be nice to create a plugin to enable multi-robot in a single rviz instance and toggle control of each robot.

@orduno orduno force-pushed the multi-robot/multi-robot_launch_files branch from 0d35bed to 92ed9a7 Compare September 23, 2019 20:23
@orduno orduno force-pushed the multi-robot/multi-robot_launch_files branch from 92ed9a7 to 414cf80 Compare September 25, 2019 22:07
@orduno
Copy link
Copy Markdown
Contributor Author

orduno commented Sep 26, 2019

Outside the scope of this PR, but it would be nice to create a plugin to enable multi-robot in a single rviz instance and toggle control of each robot.

Yes, I've got that on the todo list.

@orduno orduno merged commit 70fc073 into multi-robot/multi-robot_launch_files Sep 30, 2019
orduno added a commit that referenced this pull request Oct 1, 2019
…e RVIZ instance per robot. (#1149)"

This reverts commit 70fc073.
Forsyth-Creations pushed a commit to Forsyth-Creations/navigation2 that referenced this pull request Feb 19, 2025
…avigation#1149)

* Update documentation and consolidate variable names

* Simplify private methods and further update docs

* Rename methods

* Rename method and variables

* Rename convert method

* Rename variables and improve doc

* Rename local variables

* Use std::isfinite instead of !isnan

Co-authored-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>

* Use a lowercase theta for heading

Co-authored-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>

* Make some temporary variables const

* Let update_from_position call update_from_velocity

* Explicitly set variables with 0 in constructor

* Fix docstring

* Apply consistent variable naming

Co-authored-by:  Quique Llorente <ellorent@redhat.com>

---------

Co-authored-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
Co-authored-by: Quique Llorente <ellorent@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants