Add jsonschema to pip installs for windows cookbook#52
Merged
clalancette merged 1 commit intoros-infrastructure:latestfrom Mar 8, 2023
Merged
Conversation
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
This was referenced Mar 2, 2023
nuclearsandwich
approved these changes
Mar 3, 2023
Contributor
|
I'm going to open a ros2/ci PR which incorporates this change in order to test that things install as expected before merging. |
clalancette
approved these changes
Mar 6, 2023
Contributor
clalancette
left a comment
There was a problem hiding this comment.
Looks good to me. @nuclearsandwich I'll wait for you to merge this and update ros2/ci#696.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirement for ros2/rosidl#722
Related to ros2/ci#695
See ros2/rosidl#722 (comment)