Skip to content

Install python3-jsonschema as Linux build requirement#695

Merged
clalancette merged 1 commit intoros2:masterfrom
emersonknapp:emersonknapp/jsonschema
Mar 6, 2023
Merged

Install python3-jsonschema as Linux build requirement#695
clalancette merged 1 commit intoros2:masterfrom
emersonknapp:emersonknapp/jsonschema

Conversation

@emersonknapp
Copy link
Copy Markdown
Contributor

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Copy link
Copy Markdown
Member

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need an additional PR for ROS 2 CI once the cookbook is updated. But this is good for Linux support.

We do need to double check that this package is available in RHEL 9, which we're getting ready to move to for Rolling and Iron.

@clalancette
Copy link
Copy Markdown
Contributor

We do need to double check that this package is available in RHEL 9, which we're getting ready to move to for Rolling and Iron.

It seems to be available in the default appstream repositories for AlmaLinux 9, at least. @cottsay will that translate to being available in RHEL-9 as well?

Copy link
Copy Markdown
Member

@cottsay cottsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will that translate to being available in RHEL-9 as well?

It is provided by AppStream in both RHEL 8 and RHEL 9, so this looks good.

@clalancette
Copy link
Copy Markdown
Contributor

Given the latest comments, I'm going to run a quick CI for this on both Ubuntu and RHEL, then merge.

@clalancette
Copy link
Copy Markdown
Contributor

  • Linux Build Status
  • RHEL 8 Build Status
  • RHEL 9 Build Status

@clalancette clalancette merged commit 26ba6f2 into ros2:master Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants