Skip to content

support underlay workspaces when calculating topological order#87

Merged
dirk-thomas merged 1 commit intomasterfrom
topologic_order_with_underlays
Feb 8, 2014
Merged

support underlay workspaces when calculating topological order#87
dirk-thomas merged 1 commit intomasterfrom
topologic_order_with_underlays

Conversation

@dirk-thomas
Copy link
Member

@tfoote @wjwwood Please review.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be cleaner inside the if block. There's no need to update the set if there is no underlay packages.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 8a74b97.

@wjwwood
Copy link
Contributor

wjwwood commented Feb 7, 2014

+1

dirk-thomas added a commit that referenced this pull request Feb 8, 2014
…nderlays

support underlay workspaces when calculating topological order
@dirk-thomas dirk-thomas merged commit 4d6946c into master Feb 8, 2014
@dirk-thomas dirk-thomas deleted the topologic_order_with_underlays branch February 8, 2014 10:18
dirk-thomas added a commit that referenced this pull request Mar 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants